OSX crash fixes

[vircung]

I went through OSX crashes issues as well as logs attached in comments.

Master branch manual builds are compromised when SOUND flag was set:
make app NATIVE=osx RELEASE=1 OSX_MIN=10.13 TILES=1 CLANG=1 LUA=1 SOUND=1
make app NATIVE=osx RELEASE=1 OSX_MIN=10.13 TILES=1 CLANG=1 LUA=1 SOUND=1 FRAMEWORK=1

Builds without sound enabled worked just fine. That made me dig through ``makefileand lead to discovery thatSDL2_mixer.framework``` and it's content was copied over bot not linked nor included.

After changes flags FRAMEWORK and SOUND build doesn't result with compromised Cataclysm.app build. Moreover build result with omitted FRAMEWORK is suitable for installation via homebrew. Would be great

Fixes #23927, #23171, #24588

[narc0tiq]

Good find! The whole osxcross setup is foreign to me, so I didn't even have a way to debug it -- thanks for taking the time to look into it.

[vircung]

Actually it's more native osx build. Not sure yet if it'll fix issue with osxcross but for sure this PR affects builds with flag NATIVE=os.
Was kind of late yesterday so I'll try to verify cross build.

[narc0tiq]

It should work, in as much as the osxcross environment seems to have the SDL2_mixer.framework and its dependencies Ogg and Vorbis. Beyond that I couldn't say either, but if it helps, here's the build script that Jenkins uses; let me know if there are any changes I should make there -- the experimental OSX builds have been broken for a long time.

[vircung]

As far as I can tell mainline-build.zsh and Frameworks.tar.gz from oxcross directory looks fine and dandy. We can give it a try. Jenkins didn't pass build for this PR because of diff in Makefile 😕

[Inglonias]

I must stress that if this PR works, it should be merged ASAP, as this is one of the issues mentioned in the 0.D release project. I don't have access to an OSX computer for testing, or I'd test this myself...

[vircung]

@Inglonias I'm on OSX so that's one of reasons that I've managed to "fix it locally".

Here dropbox directory with both libSDL (no FRAMEWORK=1 flag) and Framework (FRAMEWORK=1 flag) builds with sound for testing.

[vircung]

Alternatively until this PR is merged flag SOUND=1 can be unset/excluded/skipped for OSX builds with TILES=1 made by Jenkins. Pozdrawiam / Best regards Jacek Nakonieczny Hackerspace Lublin www: http://hackerspace-lbn.pl/ mail: jacek@hackerspace-bln.pl mail: fundacja@hackerspace-lbn.pl

…

Wiadomość napisana przez Inglonias ***@***.***> w dniu 02.08.2018, o godz. 17:05: I must stress that if this PR works, it should be merged ASAP, as this is one of the issues mentioned in the 0.D release project. I don't have access to an OSX computer for testing, or I'd test this myself... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Leland]

You sure this closes #23839?

problem: Game crashes when I attempt to switch tile pack/zoom in

[vircung]

@Leland You're correct, it's doesn't. Sorry for confusion.

[vircung]

Is there something that this PR is missing to be merged?

[Night-Pryanik]

@vircung only lack of devs' free time is preventing this (and other) PRs from being reviewed and merged.

[ZhilkinSerg]

Fortunately I have some time now.