Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[READY] Chainsaw and a tree #24634
Conversation
DracoGriffin
reviewed
Aug 4, 2018
| @@ -4109,8 +4121,7 @@ int iuse::chop_logs( player *p, item *it, bool t, const tripoint &pos ) | |||
|
|
|||
| const ter_id ter = g->m.ter( dirp ); | |||
| if( ter == t_trunk ) { | |||
| /** @EFFECT_STR reduces time required to chop down a tree */ | |||
| moves = MINUTES( 70 - p->str_cur ) * 2 / it->get_quality( AXE ) * 100; | |||
| moves = chop_moves( p, it ); | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
From testing, it looks like there is a variable range --- it's not a static cost. For default 8 stats survivor with either chainsaw / electric chainsaw, the time it takes seems to be anywhere around 5m30s~ to 7m15s~. Survivor with all 20 stats with same chainsaws, was doing consistently around 5m~ to 5m15s~. Giving combat chainsaw Q3 seems inappropriate, especially with the description as follows, emphasis mine: |
This comment has been minimized.
This comment has been minimized.
Possible, but the variability is IMO introduced somewhere in processing of the long action and not in the code I changed. Change of character speed due to bad weather or something? I don't really know, but I bet if there is variability now, it was there before. |
This comment has been minimized.
This comment has been minimized.
Well, if your employer dropped your wage by 50%, would you consider it much less, or just a little bit less? ;-) On the other hand, I have no problem changing combat chainsaw back, I never use it anyway... Could we have opinion of more people on this one? |
This comment has been minimized.
This comment has been minimized.
sfsworms
commented
Aug 5, 2018
|
I'm with robik. Twice the time is way worse than the chainsaw, and giving it woodcutting ii would only make it as good as a wood saw, which seems bad for a powered too |
This comment has been minimized.
This comment has been minimized.
|
I suggest that the wood axe be bumped back up to axe 3 now as well to differentiate it from the other axes not built for woodcutting |
This comment has been minimized.
This comment has been minimized.
|
Okay, so far these are suggested changes.
I have no problem with either of these, but decision ultimately lies with people with merging rights. Feel free to merge this one with necessary tuning or just post balancing changes that need to be done before merging and I will commit them into the PR. |
Robik81 commentedAug 4, 2018
Closes #23704
As I noted in issue mentioned above, tree cutting with chainsaw took way too long.
To solve this isse, I used formula (60-STR) / (2^(AXE-1) ) suggested by Maddremor. One small difference is that for powered tools it uses DEX instead of STR.
For person with STR / DEX 8:
Q1 - 52m
Q2 - 26m
Q3 - 13m - moved combat chainsaw here (from Q1)
Q4 - 6m - moved chainsaw here (from Q3)
Times for various tool quality and attributes is nicely presented in Maddremor post in the issue thread.