Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Chainsaw and a tree #24634

Merged
merged 2 commits into from Aug 9, 2018

Conversation

Projects
None yet
5 participants
@Robik81
Copy link
Contributor

commented Aug 4, 2018

Closes #23704

As I noted in issue mentioned above, tree cutting with chainsaw took way too long.

To solve this isse, I used formula (60-STR) / (2^(AXE-1) ) suggested by Maddremor. One small difference is that for powered tools it uses DEX instead of STR.

For person with STR / DEX 8:
Q1 - 52m
Q2 - 26m
Q3 - 13m - moved combat chainsaw here (from Q1)
Q4 - 6m - moved chainsaw here (from Q3)

Times for various tool quality and attributes is nicely presented in Maddremor post in the issue thread.

src/iuse.cpp Outdated
@@ -4109,8 +4121,7 @@ int iuse::chop_logs( player *p, item *it, bool t, const tripoint &pos )

const ter_id ter = g->m.ter( dirp );
if( ter == t_trunk ) {
/** @EFFECT_STR reduces time required to chop down a tree */
moves = MINUTES( 70 - p->str_cur ) * 2 / it->get_quality( AXE ) * 100;
moves = chop_moves( p, it );

This comment has been minimized.

Copy link
@DracoGriffin

DracoGriffin Aug 4, 2018

Member

extra space here between = and chop_moves

@DracoGriffin

This comment has been minimized.

Copy link
Member

commented Aug 5, 2018

From testing, it looks like there is a variable range --- it's not a static cost. For default 8 stats survivor with either chainsaw / electric chainsaw, the time it takes seems to be anywhere around 5m30s~ to 7m15s~. Survivor with all 20 stats with same chainsaws, was doing consistently around 5m~ to 5m15s~.

Giving combat chainsaw Q3 seems inappropriate, especially with the description as follows, emphasis mine:
" "description": "This is a chainsaw that has been lightened, tuned, and extensively modified to be a more effective weapon. Unfortunately these modifications have rendered it much less effective as a woodcutting tool.","

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2018

From testing, it looks like there is a variable range --- it's not a static cost. For default 8 stats survivor with either chainsaw / electric chainsaw, the time it takes seems to be anywhere around 5m30s~ to 7m15s~. Survivor with all 20 stats with same chainsaws, was doing consistently around 5m~ to 5m15s~.

Possible, but the variability is IMO introduced somewhere in processing of the long action and not in the code I changed. Change of character speed due to bad weather or something? I don't really know, but I bet if there is variability now, it was there before.

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2018

Giving combat chainsaw Q3 seems inappropriate, especially with the description as follows, emphasis mine:
" "description": "This is a chainsaw that has been lightened, tuned, and extensively modified to be a more effective weapon. Unfortunately these modifications have rendered it much less effective as a woodcutting tool.","

Well, if your employer dropped your wage by 50%, would you consider it much less, or just a little bit less? ;-)

On the other hand, I have no problem changing combat chainsaw back, I never use it anyway... Could we have opinion of more people on this one?

@sfsworms

This comment has been minimized.

Copy link

commented Aug 5, 2018

I'm with robik. Twice the time is way worse than the chainsaw, and giving it woodcutting ii would only make it as good as a wood saw, which seems bad for a powered too

@RadHazard

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

I suggest that the wood axe be bumped back up to axe 3 now as well to differentiate it from the other axes not built for woodcutting

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2018

Okay, so far these are suggested changes.

  • move combat chainsaw back to Q1
  • move wood axe to Q3

I have no problem with either of these, but decision ultimately lies with people with merging rights.

Feel free to merge this one with necessary tuning or just post balancing changes that need to be done before merging and I will commit them into the PR.

@Robik81 Robik81 changed the title Chainsaw and a tree [READY] Chainsaw and a tree Aug 8, 2018

Robik81 added some commits Aug 4, 2018

@Robik81 Robik81 force-pushed the Robik81:chainsaw branch to ccf1c33 Aug 9, 2018

@ZhilkinSerg ZhilkinSerg merged commit 8c80f54 into CleverRaven:master Aug 9, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gorgon-ghprb Build finished.
Details

@Robik81 Robik81 deleted the Robik81:chainsaw branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.