Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemoves duplicate M24 lines to fix error #24774
Conversation
DracoGriffin
added
(P2 - High)
[JSON]
<Bugfix>
labels
Aug 11, 2018
DracoGriffin
referenced this pull request
Aug 11, 2018
Closed
Error "assignment does not update value" for M24 #24769
ZhilkinSerg
merged commit 6f6d4d1
into
CleverRaven:master
Aug 11, 2018
DracoGriffin
deleted the
DracoGriffin:fix_M24_notupdated
branch
Aug 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
DracoGriffin commentedAug 11, 2018
•
edited
Fixes #24769
by removing these duplicate lines:
"reload_noise_volume": 10, "skill":"rifle",Due to using "copy-from" improperly, as they are already inherited from both:
"abstract": "rifle_base",for rifle skilland
"abstract": "gun_base",for reload noise volume.