Make mining less tedious, part 2

[Rail-Runner]

1. Changed all three ways of mining (burrowing, pickaxes and jackhammers) to be possible to do via walk-and-mine feature.
2. Burrower mutation was changed to be toggleable: while it's on, it is used to mine/till while moving. Had to remove manual activation to burrow into a single tile. Alternatively, player can activate specific actions instead of toggling dig mode.
3. Added MINEABLE flag to most terrain and furniture that is tough enough to be unlikely to be broken by hand.
4. Allowed Burrower mutation to be a substitute for having a pickaxe and a shovel, for all purposes. I had to rewrite everything related to rubble removal, but in fact it seems to be better now.

The only issue I found with this is that once player finishes burrowing (using a mutation), they are queried about whether they should stop or not, because of pain caused by digging.

[Night-Pryanik]

Allowed Burrower mutation to be a substitute for having a pickaxe and a shovel. I had to bring back pit-digging constructions to do that.

So we'll have two ways of digging pits? One, which takes digging quality of the tool into account, and another, which takes fixed 30 minutes no matter if this is performed by a digging stick or by a shovel. What's the point of this?

[Rail-Runner]

It's supposed to be a way for burrower mutants to dig pits. I couldn't figure out a better way to do it.

[Night-Pryanik]

Then I suppose it's better not to allow burrowers dig pits rather than bring back digging pits through the construction menu.

[ZhilkinSerg]

Then I suppose it's better not to allow burrowers dig pits rather than bring back digging pits through the construction menu.

I agree. Digging through item action is way better.

What we can do for Burrowiers is some way to activate mutation and give some pseudo item with DIG quality which can be activated like shovels and other tools. Something similar to Monomolecular blade CBM.

[Robik81]

It might be better to split the POWERED flag to be separate. And it already exists, it was merged with #24634

It is not listed in the JSON_FLAGS.md, which is my fault, I did not realize there is extra doc for existing flags...

[Robik81]

I made a PR which adds POWERED flag into JSON_FLAGS.md #24789

[Rail-Runner]

Not sure, but this is most likely a different thing.

[Robik81]

I use it to differentiate between tools that have AXE quality but are not powered, like a wood axe, and tools that have AXE quality and are powered, like a chainsaw.

The only difference is that chainsaw has 2 states (or rather 2 items), one for chainsaw turned off, and one for chainsaw turned on. Since jackhammer has only one state - it could be considered as permanently on.

Instead of having "DIG_TOOL_POWERED" flag, you can give the jackhammers 2 flags, that is "DIG_TOOL", like pickaxe has, and "POWERED" on top of it.

In your condition, instead of testing
u.weapon.has_flag( "DIG_TOOL_POWERED" )
you would use
u.weapon.has_flag( "DIG_TOOL" ) && u.weapon.has_flag( "POWERED" )

[ZhilkinSerg]

I agree that it would be a more clean approach to use single POWERED flag.

[Rail-Runner]

Done. Bringing back pit-digging constructions is unnecessary now.

[Night-Pryanik]

I see you copy-pasted the dig pit, tamp ground, till soil code to the burrower mutation code? I'd say this is the wrong approach, as duplicated pieces of code are prone to be forgotten when one piece of code is updated. Have you tried directly invoking iexamine::dig and all other corresponding iexamines in the burrower mutation code?

[Rail-Runner]

I tried, but couldn't get this to work.

[kevingranade]

Please remove the walk-to-till feature, this needs to be a big batch job, not slightly less micromanagement by auto-tilling while walking. The mining is ok because we're almost certainly never going to have df-style mining designation so that's probably as good as it gets.

In general, if your PR title says "something about mining", please resist the urge to add unrelated features like tilling.

[cainiaowu]

While the PR could change its name to fit its contents more, I would like to point out that balancing though player tedium is not a really good way to do game balance.
Instead of using more keypress we can consider other factor like stamina cost/ingame time cost.

[Mecares]

That is a shame tilling takes since the change to the hoe far too much keypresses. Tilling a decently sized field is now a chore for the player and not the ingame character.

[ZhilkinSerg]

Can you resolve conflicts?

[Rail-Runner]

I tried to do that, but messed up the branch because the conflict is too large. How do I do that properly in this case?

[Rail-Runner]

Seems like it's fixed now.

[Night-Pryanik]

@Mecares you can ask @Robik81 to add his fantastic zone-tilling feature from his Hybrid Inventory mod.

[Rail-Runner]

Done. Jackhammers use POWERED flag now.