Fragmentation armor fix

[kevingranade]

Fixes #24796
Fixes #24863
Drops fragment damage a bit overall, and also decreases fragment size.
The result is there are about 10x as many fragments flying around, but they deal about 1/20th the damage they did previously, so they dont defeat armor.

• cant damage power armor. (Even light)
• minimal damage to vehicles.
• minimal damage to buildings.
• avoid log spam from huge numbers of fragments.

This is built on top of the perf fix.

[kevingranade]

Well that was super not fun, it was quite a pain to generate these messages.
Even better, I'm not 100% that they're at the right level of detail, let me know what you think.

[narc0tiq]

As this will be used in, e.g., "[You are/NPC is/The Monster is] hit by %s bomb fragments", I think you want "a [large/huge] number of".

[kevingranade]

Next up is building some scenarios and testing them.
Hand grenade near car, hand grenade near shopping cart.
Near is 5 squares.
Expected result is nothing more than cosmetic damage to shopping cart.
Ok for car to lose tires and windows, nothing else should break.

Similarly, I don't expect a hand grenade to take down a wall, even adjacent.

Let me know if you have any other tests that need to happen.

[ZhilkinSerg]

Game hangs when you explode grenade in your inventory while wearing decent armor (full winter survivor suit with hood, gloves, boots, and mask).

[kevingranade]

hrm, that is a rather large number of projectiles to handle, I wonder if I can shortcut that by comparing the potential damage vs the armor and skipping all the special effects if it has no possibility of dealing damage.

Also I'll just profile it, should be pretty straightforward to reproduce, there might be something dumb happening in there... ooh, like an animation delay.

[kevingranade]

Final commit should adress the hang, player::deal_damage was drawing thousands of hitboxes for all the non-damaging fragment hits, and waiting for thousands of animation delay-length ticks.

[ZhilkinSerg]

Performance is much better now - still noticeable "Hang on a bit" message sometimes, but game doesn't hang.

Grenade explosions seems to be a little underpowered as I couldn't shatter car windshields from a single explosion, but it looks the same in master branch.

I guess it is good to be merged now.

[kevingranade]

That's working as expected, fragment shouldn't hard targets, but the blast itself would, and blasts haven't been fixed.

[narc0tiq]

I just noticed this creates lines like "The the zombie is hit..." and "The the crawling zombie....". I think you wanted critter->get_name() instead?

[KurzedMetal]

Shouldn't this merge close #24748 and probably #24861 too?

[CoroNaut]

I ran over a landmine by accident going 60kph in my bike and all it did was damage my stethoscope i was wearing by 1 point, didn't even damage the vehicle any. Is this intentional or did I get extremely lucky to not have 2 bikes with 1 wheel each?