Zone activity - farm plot tilling

[Robik81]

Summary

SUMMARY: Features "adds new Farm: Plot zone and an activity to till it"

Purpose of change

As outlined in #24826 , this PR aims at reducing tedium of farming. Tilling is first activity for Farm: Plot zone, planting etc. will follow in separate PRs.

Describe the solution

1. Designate new zone of Farm: Plot type in Zone manager.
2. Perform Zone activity - formerly Sort out loot, was renamed to Zone activities (shortcut Shift+O).
3. Choose Till farm plots, if more than one activity is available.
4. Watch your character do all the work automatically.

Additional context

Also contains code infrastructure for future fixing of #25116

[Brambor]

What you do is amazing. Haven't had time yet to test automatic-sorting #24488 and I don't want to get into compiling, so haven't tested that yet as well, but it sounds amazing!

[Brambor]

Btw, this should resolve all the "hoe is now worse since it can dig" type of issues, if there are any.

[ZhilkinSerg]

Looks really great :)

[Robik81]

Damn, you people are on the roll. That was what, 50 PRs merged in last two days or something?

@Brambor Thank you, I sincerely hope the feature will serve well all aspiring farmers in this great game.

[ZhilkinSerg]

I believe this line should be:

p->moves -= 300; - i.e. subtract 300 from player moves.

Now it sets player moves to -300 which makes following check (if( p->moves <= 0 ) {) redundant as this expression will always be true.

[Robik81]

Yeah, I think you are correct, that was my intended behavior... not that I came with the formula, I stole these 3 lines from iuse::makemound and I did not check them properly I guess. I think it should be changed in both places. I would normally not duplicate the code, but I did, as this was only 3 lines.

Should I make a PR to add a cost to game_constants.h and use the value in both places? I think it is better than making extra function with just 3 lines of code.

[ZhilkinSerg]

No new function is necessary right now and you can simply change values in existing places.

Btw, you can also use following syntax: p->mod_moves( -300 );

[Robik81]

Fix is in #25253 , tested both manual and automatic tilling.