Zone activity - farm plot planting

[Robik81]

Summary

SUMMARY: Features "adds new option for Farm: Plot zone to attach specific seed and new activity to plant in nearby plot zones"

Purpose of change

As outlined in #24826 , this PR aims at reducing tedium of farming. Follow up of #25125 . Planting activity for Farm: Plot zone. Watering, weeding and fertilizing will follow in separate PRs.

Describe the solution

1. Select seed for existing Farm: Plot zone (via Edit->Edit options in zone manager) or select seed while creating a new one
2. After Tilling farm plots activity, perform Plant seeds activity (shortcut Shift+O).
3. Watch your character do all the work automatically.

Update

Watering, weeding and fertilizing will follow if / when the improved crop farming is implemented again.

[Vasyan2006]

I'm still planning to separate >Watering, weeding and fertilizing into new functions, so you will be able to use your tumba-jumba zone magic and apply them over every tile. I suppose it will be faster to commit such changes into your branch rather then opening new PR.

[Robik81]

I suppose it will be faster to commit such changes into your branch rather then opening new PR.

I think if you'l make tiny PR only with refactoring of a function into two, @ZhilkinSerg can review and merge something like this quite fast?

[Robik81]

What comment says.

[Qrox]

I guess it is because there's a timeout set in the input manager (for blinking), so when the timeout is triggered in the submenu, it thinks it is an unbound key, and returns because return_invalid is true.

See here:
https://github.com/CleverRaven/Cataclysm-DDA/blob/c27cf5e2335d55cb13cf97e8b47b485b51b6c5d2/src/game.cpp#L8420

I'll let uimenu handle it properly in my PR. For now you may want to temporarily disable the timeout before calling up the submenu.

[Robik81]

Your guess was correct. That was indeed a problem.

Thank you very much for helping me out.

(I see you are going to handle it on the uimenu side, cool.)

[ZhilkinSerg]

#25204 is merged

[Robik81]

Thank you guys.

On the weeding I go... it will be in separate PR though, this one is big enough as it is.

[Robik81]

Given that PR #24291 was rolled back, I updated this PR to work with the old planting system.

[ZhilkinSerg]

Should probably add period after Planted %s

[ZhilkinSerg]

No feedback for player (in message log or popup) when Plant items action is selected, but plant zone is not defined or plant zone has no seeds selected in its options.

[Robik81]

No feedback for player (in message log or popup) when Plant items action is selected, but plant zone is not defined or plant zone has no seeds selected in its options.

There is feedback if no compatible zone is nearby:

There is no feedback if you have only Unsorted loot zone defined but there is nothing to sort (i'l write it down as sort loot issue). You can't pick any farm related action in this case though.

If you have plant zone, but is not tilled, have no seed attached, or you have no seeds, there is also not any feedback. This one is probably the one you are referring to.

I'll fix the issue.

[Robik81]

New commits changes

• extra dot in Planted %s message
• action menu now checks if you have any seeds at all (planting disabled if not)
• added message "You planted all seeds you could." after planting action is finished (whether you planted anything or not)