Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upPrevent item controller generated corpses from becoming game crashing bombs: add itype.corpse, default to mon_null (human). Replace typeId string cmp with pointer NULL check prior to using pointer #2527
Conversation
atomicdryad
added some commits
Aug 19, 2013
This comment has been minimized.
This comment has been minimized.
CataJenkins
commented
Aug 19, 2013
|
Build successful! |
kevingranade
merged commit 5c27daa
into
CleverRaven:master
Aug 20, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
atomicdryad commentedAug 19, 2013
This is evident in spider caves, which can lead to inevitable crash via:
mapgen(ot_spider_pit_under) -> place_items("spider") -> item_groups.json("corpse") -> spawn_item -> item_controller->create -> itype("corpse"),
which does not fill in "corpse" variable'. Eventually when this bogus corpse is parsed via map::drawsq -> item.color, segfault.
This is also due to functions in item.cpp checking 'typeId() == "corpse"', instead of 'corpse != NULL'