Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces spawning joint_lit with joint in the dispensary building. #25669

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
3 participants
@Soyweiser
Copy link
Contributor

commented Sep 17, 2018

Summary

SUMMARY: Bugfixes "dispensary no longer spawns broken joint_lit, replaced with normal joint."

Purpose of change

Replaces spawning joint_lit with inactive joint items. As spawning lit joints doesn't spawn them as active, which means they are broken and never run out, nor provide a buff.

As mentioned here : https://discourse.cataclysmdda.org/t/found-a-lit-joint/16606

Describe the solution

Simply replaced the joint_lit with joint item.

* Replaces spawning joint_lit with inactive joint items. As spawning …
…lit joints doesn't spawn them as active, which means they are broken and never run out, nor provide a buff.

@ZhilkinSerg ZhilkinSerg merged commit a7a0f30 into CleverRaven:master Sep 18, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
gorgon-ghprb Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.4%) to 25.423%
Details

@Soyweiser Soyweiser deleted the Soyweiser:permajoint branch Sep 18, 2018

@KurzedMetal

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2018

@Soyweiser you forgot to add the "category" of the SUMMARY.

The format is: SUMMARY: Category "description"
The categories to choose from are: Features, Content, Interface, Mods, Balance, Bugfixes, Performance, Infrastructure, Build, I18N

Please, edit and fix it if possible, I'd love checking how the GitHub API behaves after an edit.

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2018

Like this?

@KurzedMetal

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2018

No, it should be only one SUMMARY line per PR and in your case something I'd use something like:

SUMMARY: Bugfixes "Replace broken joint_lit with normal joint when generating Dispensary"

"Category" should be one of the words I mention up there, not a fixed string.

A another example, for a Feature pull request, you could use:

SUMMARY: Features "Liquids unloaded on a sink tile disappear going down the drain"

BTW, the code formatting is optional IIRC.

@Soyweiser Soyweiser changed the title * Replaces spawning joint_lit with joint in the dispensary building. Replaces spawning joint_lit with joint in the dispensary building. Sep 19, 2018

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2018

Ow yikes, my bad, lack of reading comprehension strikes again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.