Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upReplaces spawning joint_lit with joint in the dispensary building. #25669
Conversation
ZhilkinSerg
merged commit a7a0f30
into
CleverRaven:master
Sep 18, 2018
Soyweiser
deleted the
Soyweiser:permajoint
branch
Sep 18, 2018
This comment has been minimized.
This comment has been minimized.
|
@Soyweiser you forgot to add the "category" of the SUMMARY. The format is: Please, edit and fix it if possible, I'd love checking how the GitHub API behaves after an edit. |
This comment has been minimized.
This comment has been minimized.
|
Like this? |
This comment has been minimized.
This comment has been minimized.
|
No, it should be only one SUMMARY line per PR and in your case something I'd use something like:
"Category" should be one of the words I mention up there, not a fixed string. A another example, for a Feature pull request, you could use:
BTW, the code formatting is optional IIRC. |
Soyweiser
changed the title
* Replaces spawning joint_lit with joint in the dispensary building.
Replaces spawning joint_lit with joint in the dispensary building.
Sep 19, 2018
This comment has been minimized.
This comment has been minimized.
|
Ow yikes, my bad, lack of reading comprehension strikes again. |
Soyweiser commentedSep 17, 2018
•
edited
Summary
SUMMARY: Bugfixes "dispensary no longer spawns broken joint_lit, replaced with normal joint."
Purpose of change
Replaces spawning joint_lit with inactive joint items. As spawning lit joints doesn't spawn them as active, which means they are broken and never run out, nor provide a buff.
As mentioned here : https://discourse.cataclysmdda.org/t/found-a-lit-joint/16606
Describe the solution
Simply replaced the joint_lit with joint item.