Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upChange islot_tool::revert_to to optional<itype_id> #25723
Conversation
nexusmrsep
added
the
Code: Astyle / Optimization
label
Sep 20, 2018
BevapDin
force-pushed the
BevapDin:mnt
branch
Sep 23, 2018
BevapDin
force-pushed the
BevapDin:mnt
branch
to
6d8e5d4
Sep 23, 2018
ZhilkinSerg
self-assigned this
Sep 23, 2018
ZhilkinSerg
merged commit 08a96f1
into
CleverRaven:master
Sep 23, 2018
ZhilkinSerg
removed their assignment
Sep 23, 2018
mlangsdorf
referenced this pull request
Sep 24, 2018
Merged
Various fixes for vehicle part JSON bugs #25808
BevapDin
deleted the
BevapDin:mnt
branch
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BevapDin commentedSep 20, 2018
SUMMARY: None
Change the type to better reflect what it is: an optional id of an item type. Using "null" in JSON is now invalid for this property (but you can use a JSON-null if really needed).