Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed possible undef behaviour when removing fields (Discovered by Rorudo) #2574

Closed
wants to merge 1 commit into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@1942rob @CataJenkins @kevingranade
@1942rob
Copy link
Contributor

commented Aug 21, 2013

in step_in_field() and mon_in_field()

May have fixed #2558 (couldn't reproduce it to begin with)
Probably fixed most, if not all #2209 crashes.

thread
@CataJenkins

This comment has been minimized.

Sign in to view
Copy link

commented Aug 21, 2013

Build successful!
Refer to this link for build results: http://ci.narc.ro/job/Cataclysm-PullRequests/490/

@1942rob 1942rob closed this Aug 21, 2013

Robert Sørlie
Fixed possible undef behaviour when removing fields 
in step_in_field() and mon_in_field()
680cbe1

@1942rob 1942rob reopened this Aug 21, 2013

@CataJenkins

This comment has been minimized.

Sign in to view
Copy link

commented Aug 21, 2013

Build successful!
Refer to this link for build results: http://ci.narc.ro/job/Cataclysm-PullRequests/493/
@kevingranade

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 22, 2013

Thanks for figuring out what's happening, but I think I have a non-hacky solution.

@kevingranade kevingranade referenced this pull request Aug 22, 2013

Merged

Proper field iteration #2596

@1942rob 1942rob closed this Aug 22, 2013

@1942rob 1942rob deleted the 1942rob:crashfix-x-in-field branch Aug 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.