Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMore hints and tips #26354
Conversation
AMurkin
reviewed
Oct 22, 2018
|
Two spaces. Oxford comma. Typos. |
data/core/tips.json Outdated
data/core/tips.json Outdated
data/core/tips.json Outdated
data/core/tips.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
AMurkin
and others
added some commits
Oct 22, 2018
nexusmrsep
added
the
Info / User Interface
label
Oct 22, 2018
nexusmrsep
added
the
[JSON]
label
Oct 22, 2018
data/core/tips.json Outdated
data/core/tips.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
data/json/npcs/hints.json Outdated
Qrox
and others
added some commits
Oct 23, 2018
Night-Pryanik
reviewed
Oct 23, 2018
data/core/tips.json
Outdated
| { | ||
| "type": "snippet", | ||
| "category": "tip", | ||
| "text": [ "Don’t get caught with your pants down. There’s no toilet paper anymore anyway." ] |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
Oct 23, 2018
Member
Don’t.... What is the symbol here between n and t? Shouldn't it be '? Also for There’s....
This comment has been minimized.
This comment has been minimized.
ZhilkinSerg
merged commit ccc19c8
into
CleverRaven:master
Nov 3, 2018
nexusmrsep
deleted the
nexusmrsep:more_tips
branch
Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nexusmrsep commentedOct 22, 2018
Summary
SUMMARY: Content "New snippets for tips of the day and NPC hints."Purpose of change
Giving more hints and tips to the players. Some are lore-based in-game NPC hints, few other are good general tips of the day.
Describe the solution
More tips and hints. Most were gathered here: https://discourse.cataclysmdda.org/t/tip-of-the-day-suggestions/16665 Some were despoilerized, rewritten, and / or generalized. All were sorted, by the criteria what is applicable on welcome screen and what goes well in in game NPC chat. We don't want to give out too much or keep players by their hands, just a poke in the right direction.
Describe alternatives you've considered
Hints from NPC are available at Evac Shelter, and that to late in game to have any relevance. IMHO companions should give out hints, one per day. This I might do in a separate PR.
Additional context
I want to thank our community for giving great ideas for the tips on the Discourse thread.
That is still a valid place for new ideas.