Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More hints and tips #26354

Merged
merged 42 commits into from Nov 3, 2018

Conversation

Projects
None yet
5 participants
@nexusmrsep
Copy link
Contributor

commented Oct 22, 2018

Summary

SUMMARY: Content "New snippets for tips of the day and NPC hints."

Purpose of change

Giving more hints and tips to the players. Some are lore-based in-game NPC hints, few other are good general tips of the day.

Describe the solution

More tips and hints. Most were gathered here: https://discourse.cataclysmdda.org/t/tip-of-the-day-suggestions/16665 Some were despoilerized, rewritten, and / or generalized. All were sorted, by the criteria what is applicable on welcome screen and what goes well in in game NPC chat. We don't want to give out too much or keep players by their hands, just a poke in the right direction.

Describe alternatives you've considered

Hints from NPC are available at Evac Shelter, and that to late in game to have any relevance. IMHO companions should give out hints, one per day. This I might do in a separate PR.

Additional context

I want to thank our community for giving great ideas for the tips on the Discourse thread.
That is still a valid place for new ideas.

@AMurkin
Copy link
Contributor

left a comment

Two spaces. Oxford comma. Typos.

Show resolved Hide resolved data/core/tips.json Outdated
Show resolved Hide resolved data/core/tips.json Outdated
Show resolved Hide resolved data/core/tips.json Outdated
Show resolved Hide resolved data/core/tips.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated

AMurkin and others added some commits Oct 22, 2018

Update data/core/tips.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/core/tips.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/core/tips.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/core/tips.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>

@nexusmrsep nexusmrsep added the [JSON] label Oct 22, 2018

@Qrox
Copy link
Contributor

left a comment

Grammar, typos, spaces, etc

Show resolved Hide resolved data/core/tips.json Outdated
Show resolved Hide resolved data/core/tips.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated
Show resolved Hide resolved data/json/npcs/hints.json Outdated

Qrox and others added some commits Oct 23, 2018

Update data/core/tips.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/core/tips.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
Update data/json/npcs/hints.json
Co-Authored-By: nexusmrsep <nexus.mrsep@gmail.com>
{
"type": "snippet",
"category": "tip",
"text": [ "Don’t get caught with your pants down. There’s no toilet paper anymore anyway." ]

This comment has been minimized.

Copy link
@Night-Pryanik

Night-Pryanik Oct 23, 2018

Member

Don’t.... What is the symbol here between n and t? Shouldn't it be '? Also for There’s....

This comment has been minimized.

Copy link
@nexusmrsep

nexusmrsep Oct 23, 2018

Author Contributor

Oh joys of copypasta. Fixing.

@ZhilkinSerg ZhilkinSerg merged commit ccc19c8 into CleverRaven:master Nov 3, 2018

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 26.011%
Details
gorgon-ghprb Build finished.
Details

@nexusmrsep nexusmrsep deleted the nexusmrsep:more_tips branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.