Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companions (NPCs) provide general advice (hints) #26357

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@nexusmrsep
Copy link
Contributor

commented Oct 22, 2018

Summary

SUMMARY: Features "Companions provide general advice (hints)"

Purpose of change

Hints that were designed to lead new players were only given by one NPC in a Refugee Center. Problem with this is: if you got to Refugee Center its probably mid- or late-game and you don't need much hints anymore at that point.

Describe the solution

  • Allowed any companion to provide hints.
  • First you need to persuade your Companion, and there is one in 3 chance that your NPC friend will get tired of giving advice and will need to rest for one hour before providing anything more.
  • This uses same lock as training, so getting trained by NPC will block the tip option for relevant time, and other way around.

Describe alternatives you've considered

none considered

Additional context

N/A

@mlangsdorf

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2018

Come on, I just finished moving all that stuff OUT of the C++ code, please don't put it back in.

Please rebase on top of #25432, which has a dynamic_line option for give_hint and flexible dialogue effects for setting effects on the player or NPC. It's up to you if you want add a conditional effect parser or not.

@nexusmrsep

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2018

Ugh, sorry. You're absolutely right. I'll wait for when your PR gets merged and apply it then accordingly. Closing for now.

@nexusmrsep nexusmrsep closed this Oct 22, 2018

@nexusmrsep nexusmrsep deleted the nexusmrsep:companion-tips branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.