Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCompanions (NPCs) provide general advice (hints) #26357
Conversation
nexusmrsep
added
<Enhancement / Feature>
NPC / Factions
labels
Oct 22, 2018
This comment has been minimized.
This comment has been minimized.
|
Come on, I just finished moving all that stuff OUT of the C++ code, please don't put it back in. Please rebase on top of #25432, which has a dynamic_line option for give_hint and flexible dialogue effects for setting effects on the player or NPC. It's up to you if you want add a conditional effect parser or not. |
This comment has been minimized.
This comment has been minimized.
|
Ugh, sorry. You're absolutely right. I'll wait for when your PR gets merged and apply it then accordingly. Closing for now. |
nexusmrsep
closed this
Oct 22, 2018
nexusmrsep
deleted the
nexusmrsep:companion-tips
branch
Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nexusmrsep commentedOct 22, 2018
Summary
SUMMARY: Features "Companions provide general advice (hints)"Purpose of change
Hints that were designed to lead new players were only given by one NPC in a Refugee Center. Problem with this is: if you got to Refugee Center its probably mid- or late-game and you don't need much hints anymore at that point.
Describe the solution
Describe alternatives you've considered
none considered
Additional context
N/A