Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix assigned letter disappearing when taking weapon out of holster #26521
Conversation
Qrox
force-pushed the
Qrox:fix-17789
branch
to
0936141
Nov 4, 2018
ZhilkinSerg
self-assigned this
Nov 4, 2018
ZhilkinSerg
added
Info / User Interface
[C++]
<Bugfix>
labels
Nov 4, 2018
ZhilkinSerg
merged commit 5f1d57a
into
CleverRaven:master
Nov 4, 2018
ZhilkinSerg
removed their assignment
Nov 4, 2018
Qrox
deleted the
Qrox:fix-17789
branch
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Qrox commentedNov 4, 2018
Summary
SUMMARY: Bugfixes "Fix assigned letter disappearing when taking weapon out of holster"Purpose of change
Fixes #17789. When auto inventory letter is on, assigned letter of holstered weapons may disappear when taken out.
Describe the solution
Use
inventory::update_invletinstead ofinventory::assign_empty_invletinplayer::wield_contentsso inventory letter is properly updated.