Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "Improve monster tracker by eliminating the unecessary vector member." #26687
Conversation
ZhilkinSerg
added
(P2 - High)
Spawn
[C++]
Monsters
labels
Nov 14, 2018
This comment has been minimized.
This comment has been minimized.
|
I also got some extreme slowdown and then a crash in one game, so this is a welcome revert. Odd thing was I was out in the woods and there is no save as it was right at the start. |
boydkr
referenced this pull request
Nov 14, 2018
Closed
Scan for a match instead of position lookup #26693
kevingranade
merged commit ae643fe
into
master
Nov 15, 2018
6 checks passed
continuous-integration/appveyor/branch
AppVeyor build succeeded
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
coverage/coveralls
Coverage decreased (-0.03%) to 26.385%
Details
gorgon-ghprb
Build finished.
Details
This comment has been minimized.
This comment has been minimized.
|
Looking through the buggy code this replaced, I see a spelling error on line 198 in savegame.cpp: " data.read( "last_taget", target_position );" Not sure that's the culprit, but it looks wrong to me. |
ZhilkinSerg
added a commit
that referenced
this pull request
Nov 15, 2018
kevingranade
deleted the
revert-26106-tracker-uses-map
branch
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedNov 14, 2018
SUMMARY: None
Reverts #26106
There are a number of reports that creature spawning (or maybe deletion, the mechanism is unclear) is broken by this PR, so I'm reverting for now to remove the bug while we investigate.