New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding astyle to deb/ubuntu packages #27049

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@brobey8
Copy link
Contributor

brobey8 commented Dec 10, 2018

I think this should be added as if you follow the steps in CONTRIBUTING.MD and then this file you will find astyle missing when you make.

Summary

SUMMARY: Build "Adding astyle to deb/ubuntu packages"

Purpose of change

Add required package to stop warning when making.

Describe the solution

Advises users to install package

Additional context

My first PR. Hope everything is all good :)

Update COMPILING.md
I think this should be added as if you follow the steps in CONTRIBUTING.MD and then this file you will find astyle missing when you make.
@mlangsdorf

This comment has been minimized.

Copy link
Contributor

mlangsdorf commented Dec 10, 2018

Your summary line is wrong. It should be something like:
SUMMARY: Build "Adding astyle to deb/ubuntu packages"

Other than that, it's a good idea and thanks for doing this.

@brobey8

This comment has been minimized.

Copy link
Contributor

brobey8 commented Dec 10, 2018

@mlangsdorf Thanks for that. I've updated now.

@mlangsdorf

This comment has been minimized.

Copy link
Contributor

mlangsdorf commented Dec 11, 2018

Jenkins rebuild

@kevingranade kevingranade merged commit eaca082 into CleverRaven:master Dec 11, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gorgon-ghprb Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment