New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vagabond Profession #27077

Merged
merged 10 commits into from Jan 6, 2019

Conversation

Projects
None yet
4 participants
@iamlcarus
Copy link
Contributor

iamlcarus commented Dec 12, 2018

SUMMARY: Content "Added Vagabond profession."

Simply adds a Vagabond profession.
I felt dissatisfied with the Hobo profession since it seems more to be a jokey/stereotypical representation of a homeless person(they literally start with a bindle), rather than an example of a capable survivor. After all, if homeless people are used to living without many of life's amenities, wouldn't they be more well-suited to the apocalypse than most other survivors?
Sorry if there's something I did wrong with the formatting, my first time ever making a PR.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

Night-Pryanik commented Dec 12, 2018

Please use linter (http://dev.narc.ro/cataclysm/format.html) to properly format your changes.

Night-Pryanik and others added some commits Dec 12, 2018

Update data/json/professions.json
Co-Authored-By: iamlcarus <34051295+iamlcarus@users.noreply.github.com>
Update data/json/professions.json
Co-Authored-By: iamlcarus <34051295+iamlcarus@users.noreply.github.com>
Update data/json/professions.json
Co-Authored-By: iamlcarus <34051295+iamlcarus@users.noreply.github.com>
Update data/json/professions.json
Co-Authored-By: iamlcarus <34051295+iamlcarus@users.noreply.github.com>
Update data/json/professions.json
Co-Authored-By: iamlcarus <34051295+iamlcarus@users.noreply.github.com>
@iamlcarus

This comment has been minimized.

Copy link
Contributor

iamlcarus commented Dec 12, 2018

Please use linter (http://dev.narc.ro/cataclysm/format.html) to properly format your changes.

Thank you, it should be properly formatted now.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

Night-Pryanik commented Dec 12, 2018

Also please add a summary line for our auto-changelog-maker which should look like SUMMARY: Content "Added Vagabond profession."

@I-am-Erk

This comment has been minimized.

Copy link
Contributor

I-am-Erk commented Dec 12, 2018

I think you've way overstated the skillset of the average homeless wanderer... You're going from overly negative stereotypes in the Hobo profession over the other side to overly positive ones. Most people living on the street have a basic blue collar labour sort of skillset. Probably fabrication 2, maybe cooking 1, maybe tailoring 1, unarmed 1. You've given them a pretty broad set at a pretty good starting level, and without the negatives thrown in its hard to see what would have led to this person living on the street.

I loved the idea brought up in discord of giving this profession a randomized negative trait from a list, using the same trait groups code as NPC classes used.

Show resolved Hide resolved data/json/professions.json Outdated
Show resolved Hide resolved data/json/professions.json
Show resolved Hide resolved data/json/professions.json
Show resolved Hide resolved data/json/professions.json Outdated
Show resolved Hide resolved data/json/professions.json Outdated
Show resolved Hide resolved data/json/professions.json Outdated

@ZhilkinSerg ZhilkinSerg removed their assignment Dec 19, 2018

ZhilkinSerg and others added some commits Dec 21, 2018

Update data/json/professions.json
Co-Authored-By: iamlcarus <34051295+iamlcarus@users.noreply.github.com>
Update data/json/professions.json
Co-Authored-By: iamlcarus <34051295+iamlcarus@users.noreply.github.com>

@ZhilkinSerg ZhilkinSerg merged commit fd075c2 into CleverRaven:master Jan 6, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
gorgon-ghprb Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment