Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUnhardcoded comfort, warmth and feet fire bonus values for furniture #27202
Conversation
This comment has been minimized.
This comment has been minimized.
|
Two suggestions: |
This comment has been minimized.
This comment has been minimized.
|
I was thinking about warmth too, but didn't notice ids are being used in I guess it is time to move comfort levels for furniture from enum to json.
|
ZhilkinSerg
force-pushed the
ZhilkinSerg:comfortable-furniture-flag
branch
from
0349046
to
ebb9d5d
Dec 20, 2018
ZhilkinSerg
changed the title
Implemented COMFORTABLE flag for furniture
Unhardcoded comfort, warmth and feet fire bonus values for furniture
Dec 20, 2018
ZhilkinSerg
removed
the
<Documentation>
label
Dec 20, 2018
ZhilkinSerg
force-pushed the
ZhilkinSerg:comfortable-furniture-flag
branch
from
aa71c3a
to
7c7ae95
Dec 20, 2018
kevingranade
merged commit 45535a6
into
CleverRaven:master
Dec 21, 2018
ZhilkinSerg
deleted the
ZhilkinSerg:comfortable-furniture-flag
branch
Dec 21, 2018
Fris0uman
added a commit
to Fris0uman/Cataclysm-DDA
that referenced
this pull request
Dec 21, 2018
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/how-to-make-comfortable-furniture-terrain/18019/10 |
NotFuji
added a commit
to NotFuji/Cataclysm-DDA
that referenced
this pull request
Jan 5, 2019
Night-Pryanik
referenced this pull request
Apr 3, 2019
Closed
JSONize Furniture/Terrain Sleep Comfort and Bedding Warmth Values #24636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ZhilkinSerg commentedDec 20, 2018
•
edited
Summary
SUMMARY: Infrastructure "Unhardcoded comfort, warmth and feet fire bonus values for furniture"Purpose of change
Unhardcoded some data for furniture and moved it to json.
Describe the solution
Moved three new fields for furniture from code to json:
comfort;floor_bedding_warmth;bonus_fire_warmth_feet.