Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pillow fort #27204

Merged
merged 6 commits into from Dec 24, 2018

Conversation

Projects
None yet
5 participants
@Fris0uman
Copy link
Contributor

commented Dec 20, 2018

Summary

SUMMARY: Content "Adds Pillow Fort as new furniture to sleep in"

Purpose of change

The cataclysm is scary and survivors need a comfy place to hide from it.

Describe the solution

Adds a new type a furniture buildable from 19 pillows and 2 blankets : the Pillow Fort. It's comfy, and function like the improvised shelter except that it is very fragile and can only be build inside.

Describe alternatives you've considered

Adding Pillow_Wall and Blanket_Door so that Survivor can realy build a pillow fort.
But I was worried that making a full height wall from pillows might be unrealistic/unbalanced

Additional context

Hopefully the relatively high number of pillow required should balance it so that it doesn't become a super_easy_to_make replacement to beds.
Also bashing a pillow fort might transform down_pillow in pillow and any kind of blankets in blankets, don't know how to fix that.

f_pillow_fort uses the COMFORTABLE flag from #27202 , so this PR can only be merged after #27202.

I'd like to make it so that while on the tile you can't see outside and can't be seen but it probably requires some actual coding so it will have to wait.

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

f_pillow_fort uses the COMFORTABLE flag from #27202 , so this PR can only be merged after #27202.

I've reworked mentioned PR to make use of explicit comfort value for various funriture.

@I-am-Erk

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

Yeah, okay, I'm cool with this.

A blanket door isn't actually a terrible idea. Can we build a doorway with a blanket currently? If not we should really be able to.

On the subject of pillow walls, I agree that shouldn't be a thing, but I was thinking that it should be possible to build emergency walls out of cardboard boxes.

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

So I used comfort and floor_bedding_warmth values to make it slighty less comfortable than a bed but just as warm.

A blanket door isn't actually a terrible idea. Can we build a doorway with a blanket currently? If not we should really be able to.

It's possible to make a curtain door and I think it does'nt require a doorway to be built.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/how-to-make-comfortable-furniture-terrain/18019/3

Show resolved Hide resolved data/json/furniture.json Outdated
Update data/json/furniture.json
Co-Authored-By: Fris0uman <41293484+Fris0uman@users.noreply.github.com>

@ZhilkinSerg ZhilkinSerg self-assigned this Dec 24, 2018

@ZhilkinSerg ZhilkinSerg merged commit e113bcf into CleverRaven:master Dec 24, 2018

0 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gorgon-ghprb Build triggered for merge commit.
Details

@ZhilkinSerg ZhilkinSerg removed their assignment Dec 24, 2018

@Fris0uman Fris0uman deleted the Fris0uman:Pillow_Fort branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.