Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cold food multiplier nerf #27395

Merged
merged 4 commits into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@Siersha
Copy link
Contributor

commented Jan 2, 2019

SUMMARY: Balance "Cold food multiplier nerf"

Summary

Morale multiplier for cold food reduced from 3x to 2x.

Purpose of change

All foods which the multiplier applies to (alcohol in particular) gives very high morale bonuses. Even more so when paired with gourmand.

Describe the solution

By reducing the multiplier from 3 to 2, this would effectively reduce the maximum morale obtained from cold foods to 2/3 its original value. Though high values may still be obtained in this way, it is much more difficult.

Describe alternatives you've considered

Nerfing gourmand's maximum allowable consumption times. This did not pass as the majority of the food items did not give as much morale consumed 6x than alcohol did when consumed only twice.

Siersha added some commits Dec 31, 2018

@kevingranade

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/book-morale-buffs/18175/20

1 similar comment
@kevingranade

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/book-morale-buffs/18175/20

@kevingranade kevingranade merged commit c818148 into CleverRaven:master Jan 5, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gorgon-ghprb Build finished.
Details
@ynemo

This comment has been minimized.

Copy link

commented on 9f3c213 Jan 12, 2019

could u plz explain how all this work?
fun_max *= 3;
fun = fun * 3 / 2;
what does it mean exually ingame ?

and static const morale_mult optimist( 1.25, 0.75 ); /how it affects?

This comment has been minimized.

Copy link
Contributor Author

replied Jan 12, 2019

@ynemo
Those "changes" were changes in the current branch which attempted to nerf gourmand. It is originally x3. That is, you were able to eat food 6x in total as it multiplied the morale cap of 2x morale by 3. In my branch, I changed it to 1.5, but reverted the change back to 3. There is no change to the actual game relating to gourmand.
The whole purpose of this commit is to revert changes back to how the game is in vanilla compared to my branch, Apologies if it's confusing since they're unnecessary commits in the first place that came out of my laziness

peperov added a commit to peperov/Cataclysm-DDA that referenced this pull request Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.