Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] [CR] forage test functions #27801
Conversation
This comment has been minimized.
This comment has been minimized.
KITbutler
commented
Jan 23, 2019
Shouldn't you multiply the stated values by 4? Or do they divide the calories by the portion size now? |
KorGgenT
added some commits
Jan 23, 2019
jbytheway
reviewed
Jan 23, 2019
KorGgenT
added some commits
Jan 23, 2019
ZhilkinSerg
added
Food / Vitamins
Code: Tests
[C++]
labels
Jan 24, 2019
kevingranade
added
the
0.D Freeze
label
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/forest-food-over-abundance/17266/3 |
ifreund
removed
the
0.D Freeze
label
Mar 8, 2019
This comment has been minimized.
This comment has been minimized.
|
Marking as Stalled to clean up PR queue. Reopen when necessary. |
ZhilkinSerg
closed this
May 18, 2019
ZhilkinSerg
added
the
(S5 - OnHold / Stalled)
label
May 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
KorGgenT commentedJan 23, 2019
Created new functions in forage_tests.cpp to aid testing.
moved some functions out of their parent functions to aid in testing.
Summary
SUMMARY: Build "created functions to aid in forage rate testing"Purpose of change
The purpose of this is to have a saner approach to balancing foraging as a whole: underbrush and harvesting (fruits, berries, and nuts)
Describe the solution
I have created several functions that generate a forest map tile and simulated harvesting everything that's harvestable in the map tile, and counted up all the calories you would get from it. Nuts are a slight outlier, because they aren't directly edible, but they are easy enough to cook (and there's a small enough number of them) that i checked for those specific items.
NOTE: The calorie values here are based on #27542 but the test itself does not necessarily require that PR to be merged as of yet.
Additional context
The main reason this is WIP is that Kevin mentioned it needs to be optimized.
There are not any test cases as of now, as i felt the statistics required were a little bit beyond my ability.