Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make forests partially block Wind Turbines output #27846

Merged
merged 5 commits into from Jan 27, 2019

Conversation

4 participants
@davidpwbrown
Copy link
Contributor

commented Jan 24, 2019

Summary

SUMMARY: Features "Forests now partially block wind turbines output"

Purpose of change

Forests already partially block windchill calculation for players, so it stands to reason that it would do the same for the wind that reaches Wind Turbines.
Also I have increased the Wind Turbine power output - the previous output was based on the previous wind system, now the wind system is lower strength on average, the wind turbine needs to be set to the same balance ( the equivalent of around 40W ) , currently anyone using it would take 2 days or so to fill a car battery, now it is more like 16 hours ( in Spring )

Describe the solution

Used the existing get_local_windpower code for the overmap terrain the turbine is on.

Describe alternatives you've considered

N/A

Additional context

N/A

davidpwbrown added some commits Jan 24, 2019

@davidpwbrown davidpwbrown changed the title Forests partially block Wind Turbines output Make forests partially block Wind Turbines output Jan 24, 2019

@mlangsdorf mlangsdorf added this to In progress in Extended Vehicle Tune-Up via automation Jan 25, 2019

@ZhilkinSerg ZhilkinSerg merged commit b3d915b into CleverRaven:master Jan 27, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gorgon-ghprb Build finished.
Details

Extended Vehicle Tune-Up automation moved this from In progress to Done Jan 27, 2019

@davidpwbrown davidpwbrown deleted the davidpwbrown:turbine_forest_wind branch Jan 27, 2019

@kevingranade

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/is-wind-turbine-a-waste-of-material-and-time/18691/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.