Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upEnergy weapons rework #2803
Conversation
swwu
added some commits
Sep 1, 2013
This comment has been minimized.
This comment has been minimized.
|
It'd be nice to have fusion packs be useful for something other than powering a fusion gun--fusion guns aren't that common. Perhaps a recipe to disassemble them to plutonium cells, if that's not already in? |
This comment has been minimized.
This comment has been minimized.
|
Yeah, AFAIK fusion packs already disassemble back into plutonium cells since the fusion pack recipe is reversible. |
kevingranade
merged commit a9451bd
into
CleverRaven:master
Sep 2, 2013
1 check passed
default
Merged build finished.
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
swwu commentedSep 1, 2013
Reworked visual effects etc on a bunch of energy weapons, see http://smf.cataclysmdda.com/index.php?topic=3061.0
The short version:
ammo_effectsfield to weapons, which will be appended to the ammo's owneffectsfield when the weapon is fired.NO_AMMOflag for weapons, which causes the weapon to not consume or require ammunition when fired.USE_UPS_20andUSE_UPS_40flags for weapons that drain 20/12 and 40/24 UPS energy per shot, respectively.game::fireso that burst-fired weapons withUSE_UPScan drain the proper amount of energy.piercefield to weapons that is added to the ammo'spiercefield when calculating armor reduction. It's optional in the JSON (defaults to 0 if not specified). Also addeditem::gun_pierce(bool), which is essentially identical toitem::gun_damage(bool)except it returns the pierce value.ammo_effectsand custom fields.make_gun_sound_effect()now makes different sounds for different volumes of energy weapons fire.