Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind pushes smoke/gas/fire/hot air. #28058

Merged
merged 4 commits into from Mar 25, 2019

Conversation

Projects
None yet
6 participants
@davidpwbrown
Copy link
Contributor

commented Feb 4, 2019

Summary

SUMMARY: Features "Wind will now affect the spread of smoke/gas/fire/hot air"

Purpose of change

With the increasing wind changes, it seems logical that gases and fire would be influenced by it.

Describe the solution

If the fire or gas or smoke is not indoors, not sheltered from the wind, and the wind is over 5mph, then it's spread direction will be influenced by the wind direction.
High winds will make fires burn hotter and shorter and spread more.
More smoke will be produced and the smoke will blow in the same direction as the wind.
This applies to poison gas, tear gas, cigarette smoke, nuclear bomb clouds, hot air, and so on.
CPU concerns limit long smoke columns and trails, and the reality bubble would limit that anyway.
If you stand upwind, and set a fire, you may well be safe from it's spread.
Once again these changes may be best served by the wind direction and power being displayed on the sidebar, which @nsklaus is working on.

Describe alternatives you've considered

N/A

Additional context

torching the starting shelter surrounded by fungal growth, with a fairly strong easterly wind. the fire is spreading mostly west and north and south. the smoke too.

image

The fire code mangled my brain a bit with it's complexity and endless indents and lambdas, apologies if I've misunderstood any of it.

@I-am-Erk

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2019

I'm not sure why this makes me so happy, but this makes me so happy.

Show resolved Hide resolved src/field.cpp Outdated
Show resolved Hide resolved src/field.cpp Outdated

@davidpwbrown davidpwbrown changed the title Wind pushes smoke/gas/fire/hot air. [WIP] Wind pushes smoke/gas/fire/hot air. Feb 9, 2019

@davidpwbrown

This comment has been minimized.

Copy link
Contributor Author

commented Feb 9, 2019

Marking as WIP, as there is a new wind system using debug overrides and fixing various things, that will make this obsolete as it is, itll need to be rebased to #28143

@ifreund ifreund removed the 0.D Freeze label Mar 8, 2019

@davidpwbrown davidpwbrown force-pushed the davidpwbrown:firewind branch from fc8f1b2 to 5697524 Mar 10, 2019

@davidpwbrown

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

rebased to master, using the new wind override system

@davidpwbrown davidpwbrown changed the title [WIP] Wind pushes smoke/gas/fire/hot air. Wind pushes smoke/gas/fire/hot air. Mar 10, 2019

@davidpwbrown

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

jenkins rebuild

@ZhilkinSerg ZhilkinSerg self-assigned this Mar 20, 2019

@kevingranade kevingranade merged commit 0b3d701 into CleverRaven:master Mar 25, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gorgon-ghprb Build finished.
Details

@ZhilkinSerg ZhilkinSerg removed their assignment Mar 25, 2019

@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/everburning-fires/19415/9

@davidpwbrown davidpwbrown deleted the davidpwbrown:firewind branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.