Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upWind pushes smoke/gas/fire/hot air. #28058
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'm not sure why this makes me so happy, but this makes me so happy. |
Brambor
reviewed
Feb 6, 2019
src/field.cpp Outdated
Brambor
reviewed
Feb 6, 2019
src/field.cpp Outdated
davidpwbrown
referenced this pull request
Feb 9, 2019
Merged
Added debug wind options and fixed various wind things #28143
davidpwbrown
changed the title
Wind pushes smoke/gas/fire/hot air.
[WIP] Wind pushes smoke/gas/fire/hot air.
Feb 9, 2019
This comment has been minimized.
This comment has been minimized.
|
Marking as WIP, as there is a new wind system using debug overrides and fixing various things, that will make this obsolete as it is, itll need to be rebased to #28143 |
ZhilkinSerg
added
the
0.D Freeze
label
Feb 10, 2019
ifreund
removed
the
0.D Freeze
label
Mar 8, 2019
davidpwbrown
added some commits
Feb 3, 2019
davidpwbrown
force-pushed the
davidpwbrown:firewind
branch
from
fc8f1b2
to
5697524
Mar 10, 2019
This comment has been minimized.
This comment has been minimized.
|
rebased to master, using the new wind override system |
davidpwbrown
changed the title
[WIP] Wind pushes smoke/gas/fire/hot air.
Wind pushes smoke/gas/fire/hot air.
Mar 10, 2019
This comment has been minimized.
This comment has been minimized.
|
jenkins rebuild |
davidpwbrown
referenced this pull request
Mar 14, 2019
Merged
Added heater and vehicle heater #28706
ZhilkinSerg
self-assigned this
Mar 20, 2019
kevingranade
merged commit 0b3d701
into
CleverRaven:master
Mar 25, 2019
ZhilkinSerg
removed their assignment
Mar 25, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/everburning-fires/19415/9 |
This was referenced Mar 29, 2019
davidpwbrown
deleted the
davidpwbrown:firewind
branch
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
davidpwbrown commentedFeb 4, 2019
Summary
SUMMARY: Features "Wind will now affect the spread of smoke/gas/fire/hot air"Purpose of change
With the increasing wind changes, it seems logical that gases and fire would be influenced by it.
Describe the solution
If the fire or gas or smoke is not indoors, not sheltered from the wind, and the wind is over 5mph, then it's spread direction will be influenced by the wind direction.
High winds will make fires burn hotter and shorter and spread more.
More smoke will be produced and the smoke will blow in the same direction as the wind.
This applies to poison gas, tear gas, cigarette smoke, nuclear bomb clouds, hot air, and so on.
CPU concerns limit long smoke columns and trails, and the reality bubble would limit that anyway.
If you stand upwind, and set a fire, you may well be safe from it's spread.
Once again these changes may be best served by the wind direction and power being displayed on the sidebar, which @nsklaus is working on.
Describe alternatives you've considered
N/A
Additional context
torching the starting shelter surrounded by fungal growth, with a fairly strong easterly wind. the fire is spreading mostly west and north and south. the smoke too.
The fire code mangled my brain a bit with it's complexity and endless indents and lambdas, apologies if I've misunderstood any of it.