Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed wind turbine location checking #28081
Conversation
davidpwbrown
added some commits
Feb 5, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/is-wind-turbine-a-waste-of-material-and-time/18691/11 |
ZhilkinSerg
added
[JSON]
Vehicles
[C++]
<Bugfix>
labels
Feb 5, 2019
ZhilkinSerg
self-assigned this
Feb 7, 2019
This comment has been minimized.
This comment has been minimized.
|
Merged to |
ZhilkinSerg
closed this
Feb 8, 2019
davidpwbrown
deleted the
davidpwbrown:turbine_fix
branch
Feb 8, 2019
ZhilkinSerg
removed their assignment
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
davidpwbrown commentedFeb 5, 2019
•
edited
Summary
SUMMARY: Bugfixes "Wind Turbines location check fixed"Purpose of change
The wind turbine location checking to see if it was sheltered by a wall was sending the absolute co-ords of the vehicles centre-of-mass instead of the parts actual location.
This meant that the wind turbine was not generating less power all the time, when next to a wall, only some of the time.
Also due to the location aggregation, multiple wind turbines were not calculating correctly, and could cause problems if some of the vehicle was indoors.
Describe the solution
fixed so that the actual part location will check the tile it's on correctly.
( also fixed the bionic weather reader again -it was calculating wrong )
also fixed the indoor /sheltered check to stop using absolute position.
Describe alternatives you've considered
Additional context