Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wind turbine location checking #28081

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@davidpwbrown
Copy link
Contributor

commented Feb 5, 2019

Summary

SUMMARY: Bugfixes "Wind Turbines location check fixed"

Purpose of change

The wind turbine location checking to see if it was sheltered by a wall was sending the absolute co-ords of the vehicles centre-of-mass instead of the parts actual location.
This meant that the wind turbine was not generating less power all the time, when next to a wall, only some of the time.
Also due to the location aggregation, multiple wind turbines were not calculating correctly, and could cause problems if some of the vehicle was indoors.

Describe the solution

fixed so that the actual part location will check the tile it's on correctly.
( also fixed the bionic weather reader again -it was calculating wrong )
also fixed the indoor /sheltered check to stop using absolute position.

Describe alternatives you've considered

Additional context

@kevingranade

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/is-wind-turbine-a-waste-of-material-and-time/18691/11

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

Merged to 0.D (and master with with #28130).

@ZhilkinSerg ZhilkinSerg closed this Feb 8, 2019

@davidpwbrown davidpwbrown deleted the davidpwbrown:turbine_fix branch Feb 8, 2019

@ZhilkinSerg ZhilkinSerg removed their assignment Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.