Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix some talk topic typos #28189
+2
−2
Conversation
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/encountered-some-bug-in-experimental-8503/18727/7 |
I-am-Erk
reviewed
Feb 13, 2019
| @@ -157,7 +157,7 @@ | |||
| "id": "TALK_REFUGEE_Aleesha_2_veryearly", | |||
| "dynamic_line": "I don't know what's up. I'm not sure what we've even doing here. They say we're supposed to wait until we can be moved to the shelter downstairs, but we've been here days and there's no word on how long we'll be waiting. It's all so stupid, and nobody can tell me anything.", | |||
| "responses": [ | |||
| { "text": "What's your story? How did you get here?", "topic": "TALK_REFUGEE_Aleesha_Story1" }, | |||
| { "text": "What's your story? How did you get here?", "topic": "TALK_REFUGEE_Aleesha_/1" }, | |||
This comment has been minimized.
This comment has been minimized.
I-am-Erk
Feb 13, 2019
Contributor
It looks like you introduced a new typo here? Unless there's a syntax I'm unaware of.
kevingranade
added some commits
Feb 13, 2019
Rivet-the-Zombie
merged commit ce3f01e
into
0.D-branch
Feb 14, 2019
kevingranade
deleted the
kevingranade-talk-topic-typos
branch
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedFeb 13, 2019
Summary
SUMMARY: NonePurpose of change
Fixes issue mentioned here
Conversation code referenced an undefined topic.
Describe the solution
Just fixes the one instance for now by fixing the typo.
Describe alternatives you've considered
We need to have some consistency checking on conversation elements to insure that all referenced elements exist, but I'm not up for doing that at the moment.