Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind Turbine fixed outside check #28229

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@davidpwbrown
Copy link
Contributor

commented Feb 16, 2019

Summary

SUMMARY: Bugfixes "Fixes the outside / sheltered check for turbines"

Purpose of change

fixes #28219
Turbines were checking if they were sheltered this meant if they were sheltered by their own vehicle, they didnt produce power.
Im sure there was a reason I used the sheltered check instead the same check solar panels use.
But right now the important thing is they at least work a bit, the nuanced edge cases can be worked on after.

Describe the solution

Checked if part position was generally "outside".
Instead of a different definition of "sheltered".

Describe alternatives you've considered

n/a

Additional context

n/a

@kevingranade

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/wind-turbine-car-not-charging-battery/18810/8

@kevingranade

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

Merged to 0.D and master.

@davidpwbrown davidpwbrown deleted the davidpwbrown:turbinefix2 branch Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.