Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upWind Turbine fixed outside check #28229
+1
−1
Conversation
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/wind-turbine-car-not-charging-battery/18810/8 |
This comment has been minimized.
This comment has been minimized.
|
Merged to 0.D and master. |
kevingranade
closed this
Feb 17, 2019
kevingranade
referenced this pull request
Feb 17, 2019
Closed
Wind turbines do not charge car battery on hippy van #28219
davidpwbrown
deleted the
davidpwbrown:turbinefix2
branch
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
davidpwbrown commentedFeb 16, 2019
Summary
SUMMARY: Bugfixes "Fixes the outside / sheltered check for turbines"Purpose of change
fixes #28219
Turbines were checking if they were sheltered this meant if they were sheltered by their own vehicle, they didnt produce power.
Im sure there was a reason I used the sheltered check instead the same check solar panels use.
But right now the important thing is they at least work a bit, the nuanced edge cases can be worked on after.
Describe the solution
Checked if part position was generally "outside".
Instead of a different definition of "sheltered".
Describe alternatives you've considered
n/a
Additional context
n/a