Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix crash on wield from inventory #28318
+27
−10
Conversation
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/problem-wielding/18901/5 |
ifreund
added
Inventory / AIM / Zones
<Bugfix>
labels
Feb 22, 2019
ifreund
force-pushed the
ifreund:fix-inventory-wield-crash
branch
from
bb2113e
to
2315dc4
Feb 22, 2019
ifreund
referenced this pull request
Feb 22, 2019
Closed
Multiple errors when wielding wooden needle (Tried to find item parent/did not found item to remove it) #28319
This comment has been minimized.
This comment has been minimized.
|
Merged to 0.D and master. |
kevingranade
closed this
Feb 23, 2019
ifreund
deleted the
ifreund:fix-inventory-wield-crash
branch
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ifreund commentedFeb 22, 2019
•
edited
Summary
SUMMARY: NonePurpose of change
Fix crash on wield from inventory caused by #28312
Edit: Fixes #28319
Describe the solution
Passing the item by reference in #28312 broke the target pointer, causing bad things to happen when trying to remove it from the source location. This pr restructures the code to always remove the item before trying to wield, then replace it if the wield does not succeed. Probably should have done it that way to start with looking back.