Follower / Faction camp summary menu and migrate to overmap

[davidpwbrown]

Summary

SUMMARY: Features "Follower / Faction camp summary menu and migrate to overmap"

Purpose of change

fixes #24360
Created a menu that uses the # key ( that the old faction menu used )
In this menu, a list of your followers will be on one tab, with a summary of their information.
On another tab, a list of your faction camps and a summary of their info.
On another tab, a list of other factions ( these don't really exist yet )

Describe the solution

There is a new list being tracked for NPC followers.
follower_ids
used with the following functions in game.cpp/h

        void add_npc_follower( const int &id );
        /** Remove follower id from follower list. */
        void remove_npc_follower( const int &id );
        /** Get list of followers. */
        std::vector<int> get_follower_list();
        /** validate list of followers to account for overmap buffers */
        void validate_npc_followers();

Validate is called on load to ensure that existing NPC followers are added to this new list from older saves.
Other NPC functions would determine if NPCs were friendly or were guarding,but only in reality bubble, there was no "master list" of followers you had obtained, even if they were miles away.
This remedies that. ( and opens the door to future remote contact via radio and so on )

For the faction camps - there was some work required to move some of their information to the overmap buffer.
You can now name the camp when creating it.
There is now an overmap_ui label like the city labels, but for camps.
The camp summary will show what is required for the next upgrade and total calories stored.

The validation for older saves with existing camps was tricky, what I've done for the moment is when the menu is opened nearby an existing camp, it adds it to the list straight away.
Players with many existing camps in a save wont see them in the menu until they visit each one and "check in" by opening the menu near them.

Various other things have been done that I hope are self-evident in the code to support the goals of this PR I had to change a lot of little things.

The code is obviously very ugly, and I expect a brutal review, this was a bit of a stretch for me.

Describe alternatives you've considered

This will be improved once #28481 is merged, that will have descriptive map of strings for the mission name.
Will want to improve functionality of this in steps.

Additional context

( that is just the default name )

[Night-Pryanik]

om_description_trunc and om_upgrade_description are VERY similar. Consider merging them into one function with overload.

[Night-Pryanik]

om_description_trunc and om_upgrade_description are VERY similar. Consider merging them into one function with overload.

[mlangsdorf]

It looks like a good start, but you're complicating the tracking of the omt_pos quite a bit and I don't get the two stage tracking of camps in the overmap.

[mlangsdorf]

It looks like a good start, but you're complicating the tracking of the omt_pos quite a bit and I don't get the two stage tracking of camps in the overmap.

[AMurkin]

No need to include trailing spaces.

[AMurkin]

No need to include trailing spaces.

[Night-Pryanik]

Consider adding a [WIP] tag if you're actively working on the PR.

[davidpwbrown]

Consider adding a [WIP] tag if you're actively working on the PR.

Not currently actively adding stuff to it, the recent addition
"removed paramters to get*description in character class" was due to one of the reviewers suggesting that on discord. there will be no more additions to it, only changes due to reviews.

[mlangsdorf]

Looks pretty good. The only thing I want to change is basecamp::pos should go away. Change it to pos_deprecated, remove it from the savegame_json. Now that camps are going to be tracked via the overmap buffer, they should have an omt_pos and a board_pos.

[mlangsdorf]

Looks pretty good. The only thing I want to change is basecamp::pos should go away. Change it to pos_deprecated, remove it from the savegame_json. Now that camps are going to be tracked via the overmap buffer, they should have an omt_pos and a board_pos.

[kevingranade]

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/new-menu-functionality-for-npcs-and-factions/19282/1