Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shotgun Arm CBM #28577

Merged
merged 8 commits into from Apr 6, 2019

Conversation

Projects
None yet
@nexusmrsep
Copy link
Contributor

commented Mar 9, 2019

Summary

SUMMARY: Features "Shotgun Arm CBM - weapon concealed in your arm"

Purpose of change

Idea from Discourse Forum.
Basically a sawn-off one barrel one-shot shotgun concealed in an arm. Activate it, your arm transforms into a shotgun, fire.
Seen on Ghost in The Shell.

Describe the solution

Added new CBM weapon. From the code side of view, for it to work properly its a strange chimera, its technically a "melee weapon cbm" (not a "gun cbm", since bio-guns use power instead of ammo) and also its "reload&fire" type - which was needed for it to properly use ammo - so it behaves a bit like a bow. However the item itself is a proper gun. This was needed because there is no other way for it to remember if it had ammo loaded after retracting it back, so it pops-up loaded again.

Describe alternatives you've considered

Re-balancing it's properties around other numbers, but it's mostly based on base shotgun with dispersion of a a hand made pipe-shotgun. Perhaps not the best of weapons, but its basically a barrel in an arm. It get the job done as a backup weapon in a pinch.

Additional context

N/A

@SourSlime

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

Sounds like the kind of thing that should damage the player from recoil if they don’t have strong joints/bones/converted their other arm to a Fusion Blaster (that way they can’t hold the gun steady with their other arm)

@thethunderhawk

This comment has been minimized.

Copy link

commented Mar 9, 2019

Sounds like the kind of thing that should damage the player from recoil [under certain circumstances].

Idk about that. From a lore standpoint I think that’s easy to work around (internal shock absorbers or whatever), and from a gameplay standpoint it’s probably already going to be a low-tier CBM (being basically just a sawn off shotgun you don’t have to use volume or encumbrance to carry) and it doesn’t need to be weakened further.

The idea that your arm transforms into a shotgun seems hard to sell lorewise though IMO. If it’s just a thing that comes out of your wrist or whatever that’d be more reasonable to me.

@Fracture64

This comment has been minimized.

Copy link

commented Mar 9, 2019

Movie Upgrade featured some cool internal weapon implants: https://www.youtube.com/watch?v=36PDeN9NRZ0&feature=youtu.be&t=103

From what I remember that technology was restricted to military, and functionally was a semi auto shotgun (there also was pistol version but it got a lot less screen time). Loading gate was above elbow though, which doesn't make sense. "Realistically" it would be located below so implant is only located in forearm. We could figure out maximum amount of shells by taking average human forearm length and dividing by shotgun shell (which one by the way? Probably should be restricted to smallest gauge in game).

@nexusmrsep

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

That reminds me that I totally forgot to add it to the distribution tables.

@Fracture64

This comment has been minimized.

Copy link

commented Mar 9, 2019

Also could be a fitting addition to Bionic Assassin, doesn't seem to fit any others professions. Razor Boy seems to be more focused on melee and Bionic Thief is not combat oriented.

@nexusmrsep

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

Another though: it probably is a good time to think of CBM cancel-out lists or bionic slots. I don't want this to stack with fusion blaster arm, but I also don't want to hard-code the mutual exclusions.

@Fris0uman

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

What would make limb replacement CBM really neat would be the ability to lose limbs.
_ Lost my arm ? Ho well let's put a shotgun there.
Sounds better than :
_ I will saw off my arm and put a shotgun there instead of weilding a normal shotgun.

@SolsticeTheTechMarine

This comment has been minimized.

Copy link

commented Mar 9, 2019

Man, this sounds a lot like Trigun to me.

@nexusmrsep

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

This doesn't replace an arm fortunately, but limb prosthetics is something I'd like to do, if it wasn't a hard nut to crack. Consider a bionic arm that is armoured by definition, that would need to be repair if it loses HP instead of natural healing of an organic limb. If it was possible code wise, then it would be possible to simulate limb loss without condemning player to certain death. This however is hard to achieve as it would require some serious changes in anatomy, healing process and other interactions. But never say never.

@dissociativity

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

If it doesn't replace arm, make it lower arm HP by 25%, it creates some weak points/holes at least in theory

@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

Alternately to lowering HP, it could add arm encumbrance since it's heavier than the none it replaces.

@paulenka-aleh

This comment has been minimized.

Copy link

commented Mar 13, 2019

Oh, finally a right way to surprise NPCs asking me to drop my freaking whatever to rob me afterwards

@nexusmrsep

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

I've added +5 encumbrance.
Should I add left-arm/right-arm variants or keep it always-left-arm only?

nexusmrsep added some commits Mar 26, 2019

@ZhilkinSerg ZhilkinSerg self-assigned this Apr 2, 2019

@nexusmrsep

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

I'm going to upgrade bionics code to allow bionic shotgun (and potential future bionic weapons) to store ammo when hidden in body.

@nexusmrsep nexusmrsep changed the title Shotgun Arm CBM [WIP] Shotgun Arm CBM Apr 3, 2019

@nexusmrsep nexusmrsep changed the title [WIP] Shotgun Arm CBM Shotgun Arm CBM Apr 5, 2019

@nexusmrsep

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

Done. Integrated shotgun can now store ammo within when being retracted, so it can be pre-loaded then activated and fired. No more "reload and shoot" mechanic. Also added code that prompts fire menu to fire the gun when its being activated, but only when its loaded.

@kevingranade kevingranade merged commit a2732eb into CleverRaven:master Apr 6, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gorgon-ghprb Build finished.
Details

@nexusmrsep nexusmrsep deleted the nexusmrsep:arm-shotgun branch Apr 6, 2019

@ZhilkinSerg ZhilkinSerg removed their assignment Apr 6, 2019

@@ -1591,6 +1600,8 @@ void bionic::deserialize( JsonIn &jsin )
invlet = jo.get_int( "invlet" );
powered = jo.get_bool( "powered" );
charge = jo.get_int( "charge" );
ammo_loaded = jo.get_string( "ammo_loaded" );

This comment has been minimized.

Copy link
@ZhilkinSerg

ZhilkinSerg Apr 6, 2019

Contributor

Causes #29336. Should use some fallback values, i.e.:

    ammo_loaded = jo.get_string( "ammo_loaded", "null" );
    ammo_count = jo.get_int( "ammo_count", 0 );
@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/what-are-some-bionics-youve-always-wanted-to-see/19101/56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.