Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upOptional lua for debugging #2862
Conversation
This comment has been minimized.
This comment has been minimized.
|
Please make us a windows makefile! |
This comment has been minimized.
This comment has been minimized.
|
@Rivet-the-Zombie You should be able to compile it by setting |
This comment has been minimized.
This comment has been minimized.
|
This particular PR with LUA=1 doesn't work yet on windows, but I mean to add support/instructions for it. Generally, the regular makefile should work just fine on windows, as does the cmakelists.txt |
This comment has been minimized.
This comment has been minimized.
|
Anybody have any idea what's the actual command(s) to compile for Windows under MinGW using the current makefile? I really have no idea what I'm doing when it comes to the compiling stage, except for what I've picked up from guides on the forums and they're no longer really up to date about this. |
This comment has been minimized.
This comment has been minimized.
|
@Rivet-the-Zombie Please keep issue and pull request discussions about the actual issue/pull request. Help for compiling on Windows would be best handled in IRC or on the forums. |
This comment has been minimized.
This comment has been minimized.
|
FYI, CMake-only support isn't ok, if the main Makefile won't build it, I'm not going to land it. |
This comment has been minimized.
This comment has been minimized.
|
Okay this is simply too useful to let rot due to percieved build 'hurdles'....thus it's fair to say help compiling is quite relevent. Mostly re; mingw building, is the official wintendo bin mingw? If so, how does it handle SDL? How is that different from msvc++? Afaik mingw build will work with a liblua.a and lua headers thrown in right where sdl is...neh? |
This comment has been minimized.
This comment has been minimized.
|
Doesn't build on Fedora and I have no idea how to make it so. |
This comment has been minimized.
This comment has been minimized.
|
...build error? |
This comment has been minimized.
This comment has been minimized.
|
Yeah, the easiest would probably be to find another Makefile that includes lua5.1 and check how they're handling cross-platform problems. |
CIB
added some commits
Sep 5, 2013
This comment has been minimized.
This comment has been minimized.
|
Okay, other than the MinGW build guide that I still need to finish(http://www.wiki.cataclysmdda.com/index.php?title=How_to_compile#MinGW_with_MSYS), this should now build on most unix-likes and windows. No idea about OS X, though I hear pkg-config exists for that as well, so it should work(after installing pkg-config and lua5.1). |
This comment has been minimized.
This comment has been minimized.
|
pkg-config on my system seems to want "lua" instead of "lua5.1", so sure if that's resolvable. |
CIB
added some commits
Oct 21, 2013
This comment has been minimized.
This comment has been minimized.
|
I was able to compile and test a few lua commands on Debian |
This comment has been minimized.
This comment has been minimized.
|
Brought up to date and re-PRed in #4337 |
CIB commentedSep 5, 2013
See the commit for more details.
I tested compilation with LUA=1 and without, but tests on more systems would be good. Right now the Makefile only includes support for the way things are set up on arch linux, since I have no damn clue where the lua 5.1 stuff is on other systems.
EDIT: I had planned to use CMake to get this to run on all systems easily, but it turns out the CMake lua51 include file is broken. So yeah, gonna have to fix up the Makefile with all the platforms.