Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upmonsters: allow pets to wear armor #28646
Conversation
Night-Pryanik
reviewed
Mar 11, 2019
src/monexamine.cpp Outdated
Night-Pryanik
reviewed
Mar 11, 2019
src/monexamine.cpp Outdated
Night-Pryanik
reviewed
Mar 11, 2019
src/monexamine.cpp Outdated
Night-Pryanik
reviewed
Mar 11, 2019
src/monexamine.cpp Outdated
This comment has been minimized.
This comment has been minimized.
|
Is that a potential begining for monster wearing stuff instead of spawning them on death or not at all ? |
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/what-are-some-things-that-should-be-in-the-cataclysm/18792/103 |
mlangsdorf
force-pushed the
mlangsdorf:pet_armor
branch
from
bddbd6b
to
1e55c9d
Mar 12, 2019
mlangsdorf
changed the title
[WIP] monsters: allow pets to wear armor
monsters: allow pets to wear armor
Mar 12, 2019
This comment has been minimized.
This comment has been minimized.
|
At this time, this is really only intended for pets like tame dogs. As a general solution for monster armor, there are a lot of complications that this does not address. |
ZhilkinSerg
self-assigned this
Mar 13, 2019
ZhilkinSerg
reviewed
Mar 16, 2019
doc/MONSTERS.md Outdated
mlangsdorf
added some commits
Mar 11, 2019
mlangsdorf
force-pushed the
mlangsdorf:pet_armor
branch
from
1e55c9d
to
948f2f5
Mar 16, 2019
ZhilkinSerg
merged commit 8041bab
into
CleverRaven:master
Mar 18, 2019
ZhilkinSerg
removed their assignment
Mar 18, 2019
mlangsdorf
deleted the
mlangsdorf:pet_armor
branch
Mar 18, 2019
DracoGriffin
referenced this pull request
Mar 30, 2019
Merged
Expand Pet Armors for Dogs [CR] #29134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mlangsdorf commentedMar 11, 2019
•
edited
Summary
SUMMARY: Features "monsters: allow pets to wear armor"Purpose of change
Fixes #28627
Allow pets to wear armor.
Describe the solution
Move pet_menu into monexamine.cpp and refactor it.
Create a new bodytype field for monsters that describes the general layout of the monster's body and assign suitable values for most mammals, zombies, fish, insects, and spiders.
Create a new islot_pet_armor which is similar to islot_armor but describes something that can be worn by a pet.
Add a new menu option that allows you to put armor on pets or remove armor from pets wearing armor.
In
monster::get_armor_cut(),monster::get_armor_bash(), andmonster::get_armor_type(), check for worn armor on the monster and add the armor's protection values.Alternatives
I considered using item properties, but an islot is more robust.
Notes
zlaves have bodytype human, and should wear non-pet armor, but that's an issue to pursue at a later date.
Someone else should probably go through and add a bunch of recipes and items for various pet armors.