Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix crash when handling non-food liquids #28700
Conversation
Hirmuolio
added some commits
Mar 14, 2019
Hirmuolio
changed the title
Hirmuolio temperature patch 1
Fix crash when handling non-food liquids
Mar 14, 2019
Hirmuolio
referenced this pull request
Mar 14, 2019
Closed
Siphoning gas to/from vehicle crashes the game, sometimes #28704
Tharn
referenced this pull request
Mar 14, 2019
Open
Reloading sealed stomach with fruit juice causes crash #28096
kevingranade
merged commit e545fa7
into
CleverRaven:master
Mar 15, 2019
Hirmuolio
deleted the
Hirmuolio:Hirmuolio-temperature-patch-1
branch
Mar 15, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/crash-while-siphoning-fuel/19234/2 |
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/crashes-bugs-etc/19233/2 |
This was referenced Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Hirmuolio commentedMar 14, 2019
•
edited
Summary
SUMMARY: Bugfixes "Fix crash when handling non-food liquids"Fixes #28704
Purpose of change
When you tried to put non food liquid into a container that was not empty the game tried to average their temperatures.
But since they were not food and had no temperature data at all this resulted the game to crash.
Describe the solution
Check if the container has food in it before trying to handle its contents as food.
Describe alternatives you've considered
Additional context