Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix errors on crafting canned/jarred/vacuumed foods #28725
Conversation
Hirmuolio
referenced this pull request
Mar 15, 2019
Closed
Game crash when making pickled veggy #28724
This comment has been minimized.
This comment has been minimized.
|
The gorgon error is probably from the extra":" in description and it should be fine now. |
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/crashes-bugs-etc/19233/2 |
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/game-crash-on-cooking-cooked-cattail-stalk/19238/2 |
Hirmuolio
referenced this pull request
Mar 15, 2019
Closed
"Assertion failed" when batch crafting broth #28739
ZhilkinSerg
self-assigned this
Mar 15, 2019
ZhilkinSerg
added
Food / Vitamins
Crafting / Construction / Recipes
[C++]
<Bugfix>
labels
Mar 15, 2019
ZhilkinSerg
removed their assignment
Mar 16, 2019
This comment has been minimized.
This comment has been minimized.
|
This is a big problem. If it's all in order, can someone merge please? |
kevingranade
merged commit a680f3e
into
CleverRaven:master
Mar 19, 2019
Hirmuolio
deleted the
Hirmuolio:Hirmuolio-jarcrash
branch
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Hirmuolio commentedMar 15, 2019
•
edited
Summary
SUMMARY: Bugfixes "Fixes game crash on jarring/canning/vacuum sealing"Purpose of change
The game would throw multiple errors when you crafted food that goes in a sealed container.
Also for recipes that heat up the result but create non food/drink items (usually as byproducts).
Fixes: #28724
Fixes: #28739
Describe the solution
Instead of applying the temperature code to both the food and the food container only the food is handled.
Describe alternatives you've considered
Additional context