Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty CBM description #28743

Merged
merged 3 commits into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@Fris0uman
Copy link
Contributor

Fris0uman commented Mar 15, 2019

Summary

SUMMARY: Content "Gives descriptions to faulty CBM item"

Purpose of change

Recent change to faulty CBM made them drop has item after removal. So instead of burnt out bionic you get Itchy Metal Thing for example.

The description on this faulty bionics is saying This is a faulty bionic, seing this is a bug. .
Well it's wrong .... It's a feature !

Describe the solution

I've edited the description of some faulty bionic to describe what you just got out of you. I've also changed some name has Bionic-Induced Deformity is not an object. I eventually ran out of idea so I edited bionic_general_faulty's description to say This CBM is broken beyond repair, you can't do anything with it.

Describe alternatives you've considered

Change the code to drop burnt ou bionic again but there was no obvious and easy way to do that.

Additional context

Faulty Bionics are just as useless as burnt out bionic : you can't craft with them and you can't break them for parts either. So game wise it's not much of a problem and it adds a bit of flavor to cbm removal.

Fris0uman added some commits Mar 15, 2019

@kevingranade

This comment has been minimized.

Copy link
Member

kevingranade commented Mar 15, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/itchy-metal-bionic/19225/7

@kevingranade kevingranade merged commit 8777f09 into CleverRaven:master Mar 15, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gorgon-ghprb Build finished.
Details

@Fris0uman Fris0uman deleted the Fris0uman:Faulty_Cbm_Description branch Mar 15, 2019

@Photoloss

This comment has been minimized.

Copy link
Contributor

Photoloss commented Mar 15, 2019

Faulty Bionics are just as useless as burnt out bionic : you can't craft with them and you can't break them for parts either.

Not entirely true as last I checked plating CBMs were still craftable from burnt out bionics. Not that doing so is a viable option due to needing superalloy, and I'm sure those recipes will eventually get removed anyway.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

Night-Pryanik commented Mar 16, 2019

CBMs are no longer craftable in vanilla.

@Photoloss

This comment has been minimized.

Copy link
Contributor

Photoloss commented Mar 16, 2019

CBMs are no longer craftable in vanilla.

So, about that...

@Night-Pryanik

This comment has been minimized.

Copy link
Member

Night-Pryanik commented Mar 16, 2019

Well, you are right, I forgot about these. Unfortunately I don't remember exactly why these 4 bionics were left craftable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.