Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add almond milk, soy milk, and a method to produce almond milk. #28771

Merged
merged 9 commits into from Mar 18, 2019

Conversation

Projects
None yet
@umsretuza
Copy link
Contributor

commented Mar 17, 2019

Summary

SUMMARY: Content "Add almond milk, soy milk, and a method to produce almond milk using shelled almonds and water."

Purpose of change

Almond milk and soy milks are increasingly more commonly found in households around the world. Used for various reasons, more notably, lactose intolerance.

Describe the solution

Seeing as you can be afflicted with lactose intolerance, why not have the chance to come across a few gallon jugs of these dairy-free milks? Or alternatively, produce almond milk with the shelled almonds one often comes across.

Describe alternatives you've considered

I've thought about other plant milk alternatives like oat milk, hemp milk, etc. but those are much less common than these two largely popular kinds. (almond and soy)

First PR! ⁽ ´◡`⁾

@TheMurderUnicorn

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

The drinks.json has some format issues. I don't know how to show them in my comment, but the {'s and }'s need to be lined up with the other ones, if that makes sense.

In the future, if you put your code in http://dev.narc.ro/cataclysm/format.html (with a [ at the start and a ] at the end), it will format your code for you.

@mlangsdorf

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

For future PRs, there's not need to put [ ] around the PR type in the summary line. It should be SUMMARY: Content "Add almond milk, soy milk, and a method to produce almond milk using shelled almonds and water." not SUMMARY: [Content] "Add almond milk, soy milk, and a method to produce almond milk using shelled almonds and water."

You were very close, though, so good job.

@mlangsdorf

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

jenkins rebuild

@Photoloss

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

The rag in the recipe probably should not be consumed but rather used as a tool, see e.g. juice pressing.

@umsretuza

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

The rag in the recipe probably should not be consumed but rather used as a tool, see e.g. juice pressing.

I thought about the rag being used as a tool, but there is the strangeness of having the rag afterward, perfectly usable. Should it be assumed that the character cleaned the rag near the end of the process?

@Photoloss

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Should it be assumed that the character cleaned the rag near the end of the process?

This is what the juice recipes do, since non-drinkable water is not very hard to come by I'd say it's the lesser of two evils over completely destroying the fabric. Aside from everything else you'd be able to use a single rag for bulk-crafting hundreds of portions of almond milk without washing it in between.

@AMurkin
Copy link
Contributor

left a comment

Two spaces between sentences.

Show resolved Hide resolved data/json/items/comestibles/drink.json Outdated
Show resolved Hide resolved data/json/items/comestibles/drink.json Outdated
Apply suggestions from code review
Co-Authored-By: umsretuza <41234092+umsretuza@users.noreply.github.com>
@int-ua

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Didn't FDA ban using "milk" for these products?

@umsretuza

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

Didn't FDA banned using "milk" for these products?

Not yet, and they have a long battle ahead of them before they get there. Especially with a recent court decision that sided firmly with "milk" being an appropriate label.

@Rail-Runner

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Might want to also add a more "primitive" version of recipe that would (I think) use a containing tool and a hammering tool in place of food processor, but taking more time.

@Ilysen

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Hey, neat! I think they could do with a small health value, though, like 1 or 2.

@KorGgenT

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

would you mind citing the nutrition facts? i just want to make sure that they're based on real life values, instead of based on other items in game. i have a hunch that almond milk in particular is probably more of a source of iron, and not vitamin A

@umsretuza

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

@KorGgenT

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

ok, then calcium should be 11 and iron should be 1. the translation is: RDA percentage * .24

@umsretuza

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

ok, then calcium should be 11 and iron should be 1. the translation is: RDA percentage * .24

I've decided to use the updated sources for both soy and almond, under the same brand and the same flavor, for consistency.

Thanks for the formula!

@ZhilkinSerg ZhilkinSerg self-assigned this Mar 18, 2019

@ZhilkinSerg ZhilkinSerg merged commit 3c1607e into CleverRaven:master Mar 18, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gorgon-ghprb Build finished.
Details

@ZhilkinSerg ZhilkinSerg removed their assignment Mar 18, 2019

@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/latest-experimental-features/5582/1106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.