Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd almond milk, soy milk, and a method to produce almond milk. #28771
Conversation
This comment has been minimized.
This comment has been minimized.
|
The drinks.json has some format issues. I don't know how to show them in my comment, but the {'s and }'s need to be lined up with the other ones, if that makes sense. In the future, if you put your code in http://dev.narc.ro/cataclysm/format.html (with a [ at the start and a ] at the end), it will format your code for you. |
This comment has been minimized.
This comment has been minimized.
|
For future PRs, there's not need to put [ ] around the PR type in the summary line. It should be You were very close, though, so good job. |
This comment has been minimized.
This comment has been minimized.
|
jenkins rebuild |
This comment has been minimized.
This comment has been minimized.
|
The rag in the recipe probably should not be consumed but rather used as a tool, see e.g. juice pressing. |
This comment has been minimized.
This comment has been minimized.
I thought about the rag being used as a tool, but there is the strangeness of having the rag afterward, perfectly usable. Should it be assumed that the character cleaned the rag near the end of the process? |
This comment has been minimized.
This comment has been minimized.
This is what the juice recipes do, since non-drinkable water is not very hard to come by I'd say it's the lesser of two evils over completely destroying the fabric. Aside from everything else you'd be able to use a single rag for bulk-crafting hundreds of portions of almond milk without washing it in between. |
AMurkin
reviewed
Mar 17, 2019
|
Two spaces between sentences. |
This comment has been minimized.
This comment has been minimized.
|
Didn't FDA ban using "milk" for these products? |
This comment has been minimized.
This comment has been minimized.
Not yet, and they have a long battle ahead of them before they get there. Especially with a recent court decision that sided firmly with "milk" being an appropriate label. |
This comment has been minimized.
This comment has been minimized.
|
Might want to also add a more "primitive" version of recipe that would (I think) use a containing tool and a hammering tool in place of food processor, but taking more time. |
umsretuza
added some commits
Mar 17, 2019
This comment has been minimized.
This comment has been minimized.
|
Hey, neat! I think they could do with a small health value, though, like 1 or 2. |
This comment has been minimized.
This comment has been minimized.
|
would you mind citing the nutrition facts? i just want to make sure that they're based on real life values, instead of based on other items in game. i have a hunch that almond milk in particular is probably more of a source of iron, and not vitamin A |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
ok, then calcium should be 11 and iron should be 1. the translation is: |
This comment has been minimized.
This comment has been minimized.
ZhilkinSerg
self-assigned this
Mar 18, 2019
ZhilkinSerg
merged commit 3c1607e
into
CleverRaven:master
Mar 18, 2019
ZhilkinSerg
removed their assignment
Mar 18, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/latest-experimental-features/5582/1106 |
umsretuza commentedMar 17, 2019
•
edited by mlangsdorf
Summary
SUMMARY: Content "Add almond milk, soy milk, and a method to produce almond milk using shelled almonds and water."Purpose of change
Almond milk and soy milks are increasingly more commonly found in households around the world. Used for various reasons, more notably, lactose intolerance.
Describe the solution
Seeing as you can be afflicted with lactose intolerance, why not have the chance to come across a few gallon jugs of these dairy-free milks? Or alternatively, produce almond milk with the shelled almonds one often comes across.
Describe alternatives you've considered
I've thought about other plant milk alternatives like oat milk, hemp milk, etc. but those are much less common than these two largely popular kinds. (almond and soy)
First PR! ⁽ ´◡`⁾