Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taste Modifier bionic #28772

Merged

Conversation

Projects
None yet
8 participants
@Night-Pryanik
Copy link
Member

commented Mar 17, 2019

Summary

SUMMARY: Content "Adds new bionic Taste Modifier"

Purpose of change

Added a new bionic that nullifies negative enjoyment value from any comestible with negative joy. In fact, it's more of a flavor/roleplay stuff as there ain't many items with negative joy value, and the values ain't so big to care about. But why not? Especially if people liked the idea.

Describe the solution

Added bionic Taste Modifier and bionic item Taste Modifier CBM. If active and player has enough bionic energy (equals to joy value), it will nullify the value of any comestible with negative joy.
Added bionic to the bionics item group spawn list.
Added bionic to the starting bionics list for Bionic Soldier, Bionic Prepper, Bionic Sniper, and Bionic Monster professions.

Additional context

Inactive bionic:
изображение

Active bionic (note that only negative values of JOY aren't shown):
изображение

Proofs:
изображение

@Rail-Runner

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Wouldn't it be better to only get it to nullify negative fun values? It might be tedious to turn it on and off for different foods (if anything, we could assume that character does it automatically).

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

Wouldn't it be better to only get it to nullify negative fun values? It might be tedious to turn in on and off for different foods (if anything, we could assume that character does it automatically).

Ok, done.

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

I don't know if this bionic suits any profession. Any suggestions?

@nexusmrsep

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Why does it only nullify negative joy? If it works by cutting the sensory neural connection to the tongue it'd be a double edged sword where you would feel nothing, no taste at all, be it good or bad, as long as it's active.

Of course it's easily bypassed by simply turning off before eating good tasty chocolate and turned on when eating awful jug of lard, but it makes much more sense this way then a targeted system.

@Rail-Runner

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Why does it only nullify negative joy? If it works by cutting the sensory neural connection to the tongue it'd be a double edged sword where you would feel nothing, no taste at all, be it good or bad, as long as it's active.

Of course it's easily bypassed by simply turning off before eating good tasty chocolate and turned on when eating awful jug of lard, but it makes much more sense this way then a targeted system.

Balancing via tedium is never a good thing. Like I said, it may be assumed that character turns it on and off automatically depending on the specific item they're about to consume.

@nexusmrsep

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Balancing via tedium is never a good thing. Like I said, it may be assumed that character turns it on and off automatically depending on the specific item they're about to consume.

Then add energy consumption for every automatic on/off action it would require, and automatic toggle to keep track if it's on/off.

@Rail-Runner

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Balancing via tedium is never a good thing. Like I said, it may be assumed that character turns it on and off automatically depending on the specific item they're about to consume.

Then add energy consumption for every automatic on/off action it would require, and automatic toggle to keep track if it's on/off.

Or just remove activation power cost and make it drain power only when it's actually useful and only if set to "on" on bionics list.

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

Or just remove activation power cost and make it drain power only when it's actually useful and only if set to "on" on bionics list.

Done.

@ZhilkinSerg ZhilkinSerg self-assigned this Mar 18, 2019

@Amoebka

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

While I like the idea, I'm a bit perplexed by the lore implications of this thing. Bionics are a new commercial technology, presumably a very expensive one. Yet this bionic is only really useful for people eating garbage foods. Surely anyone too poor to afford decent food wouldn't be able to afford a hi-tech bionic either? Who was this thing even designed for, in-universe?

@Maddremor

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Another issue is that taste is only part of disliking comestibles. Texture will remain, as will the character knowledge of them eating rotten food/insects/human flesh/whatever. A simplified solution would be to cap the negative joy that the bionic could negate.

@Fris0uman

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Could be for soldier or astronaut that are forced to eat poor tasting food in the field ?

@Amoebka

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

As for professions, Bionic Monster should definitely have this. It already has bionics that help digest rotting raw meat and such.

And if it is indeed a military tech, then Bionic Sniper as well. That one seems to be centered around surviving alone in the wilds.

@Night-Pryanik Night-Pryanik changed the title Taste Receptors Blocker bionic Taste Modifier bionic Mar 20, 2019

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

Another issue is that taste is only part of disliking comestibles. Texture will remain, as will the character knowledge of them eating rotten food/insects/human flesh/whatever. A simplified solution would be to cap the negative joy that the bionic could negate.

I enhanced bionic. Divided it into two parts, one in mouth, and the other in the brain. The mouth part intercepts various data of the comestible (such as taste or texture) from the receptors in mouth and sends it to the brain part. The brain analyzes data, and if it finds it "bad", it modifies it and sends it forth the brain. Cheated brain considers all "bad" comestibles have neutral taste.

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

As for professions, Bionic Monster should definitely have this. It already has bionics that help digest rotting raw meat and such. And if it is indeed a military tech, then Bionic Sniper as well. That one seems to be centered around surviving alone in the wilds.

Added it to Bionic Monster, Bionic Soldier, Bionic Prepper, and Bionic Sniper professions.

@ZhilkinSerg ZhilkinSerg removed their assignment Mar 26, 2019

Night-Pryanik added some commits Mar 28, 2019

@ZhilkinSerg ZhilkinSerg merged commit 0950a4a into CleverRaven:master Apr 1, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gorgon-ghprb Build finished.
Details

@Night-Pryanik Night-Pryanik deleted the Night-Pryanik:taste-receptors-blocker-cbm branch Apr 2, 2019

@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/latest-experimental-features/5582/1106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.