Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Expand and complete new surface lab #28947
Conversation
I-am-Erk
added some commits
Mar 21, 2019
I-am-Erk
changed the title
Expand and complete new surface lab
[WIP] Expand and complete new surface lab
Mar 24, 2019
Night-Pryanik
reviewed
Mar 24, 2019
| "id": "rotovap", | ||
| "type": "TOOL", | ||
| "category": "tools", | ||
| "name": "rotary evapourator", |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
Mar 24, 2019
Member
Suggested change
| "name": "rotary evapourator", | |
| "name": "rotary evaporator", |
Night-Pryanik
reviewed
Mar 24, 2019
| "type": "TOOL", | ||
| "category": "tools", | ||
| "name": "rotary evapourator", | ||
| "description": "Just looking at this thing makes you feel like a proper mad scientist. It's a series of glass tubes and round flasks, connected to a central motor and a heating element. The heating element warms one flask, kept rotating by the motor, evapourating the contents. The vapour is then condensed in the tubes and collected in another flask, in case you wanted to save it for later.", |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
Mar 24, 2019
Member
Suggested change
| "description": "Just looking at this thing makes you feel like a proper mad scientist. It's a series of glass tubes and round flasks, connected to a central motor and a heating element. The heating element warms one flask, kept rotating by the motor, evapourating the contents. The vapour is then condensed in the tubes and collected in another flask, in case you wanted to save it for later.", | |
| "description": "Just looking at this thing makes you feel like a proper mad scientist. It's a series of glass tubes and round flasks, connected to a central motor and a heating element. The heating element warms one flask, kept rotating by the motor, evaporating the contents. The vapor is then condensed in the tubes and collected in another flask, in case you wanted to save it for later.", |
Night-Pryanik
reviewed
Mar 24, 2019
| { | ||
| "id": "hydrogen_tank", | ||
| "type": "TOOL", | ||
| "name": "nitrogen tank", |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
Mar 24, 2019
Member
Suggested change
| "name": "nitrogen tank", | |
| "name": "hydrogen tank", |
Night-Pryanik
reviewed
Mar 24, 2019
| "type": "uncraft", | ||
| "skill_used": "electronics", | ||
| "difficulty": 4, | ||
| "skills_required": [ "cooking", 1 ], |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
Mar 24, 2019
Member
I assume you meant that this recipe requires chemistry? I think chemistry in form of cooking begins at level 3.
This comment has been minimized.
This comment has been minimized.
|
You're in the wrong PR, @Night-Pryanik. Those are changes from #28892 that are just inherited into this one. |
mlangsdorf
added
[JSON]
Mapgen
Character / World Generation
labels
Mar 24, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/so-i-came-across-the-research-facility-superstructure/19434/2 |
This comment has been minimized.
This comment has been minimized.
|
closing rather than fixing all these lints. |
I-am-Erk
closed this
Apr 1, 2019
I-am-Erk
deleted the
I-am-Erk:lab-surface-2
branch
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
I-am-Erk commentedMar 24, 2019
•
edited
Summary
SUMMARY: Content "Adds more mapgen variation to new surface lab"Purpose of change
This completes (I hope) #28722 by adding appropriate variety in nested mapgen and by completing the basement.
Describe the solution
Adds numerous 5x5 and 11x11 maps using more of the furniture types I added.
Additional context
If possible I'll remove the old and busted labs