Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Expand and complete new surface lab #28947

Closed
wants to merge 24 commits into from

Conversation

Projects
None yet
4 participants
@I-am-Erk
Copy link
Contributor

commented Mar 24, 2019

Summary

SUMMARY: Content "Adds more mapgen variation to new surface lab"

Purpose of change

This completes (I hope) #28722 by adding appropriate variety in nested mapgen and by completing the basement.

Describe the solution

Adds numerous 5x5 and 11x11 maps using more of the furniture types I added.

Additional context

  • Add more nested mapgen
  • Expand basement to include a maze of twisty tunnels
  • Add z-2 entry to labs
  • Add sewer connection on z-1
  • Add subway connection on z-2

If possible I'll remove the old and busted labs

I-am-Erk added some commits Mar 21, 2019

add science tools
This is a general group. Later it would be good to have a chemistry/biology/physics/engineering distinction, but this will do for now.
Reagents
General laboratory reagents and expendibles.  This list contains most conceivable chemicals in the game.  More specific lists for each type of lab would be reasonable eventually.
Start adding some deconstructions
salvage is great

@I-am-Erk I-am-Erk changed the title Expand and complete new surface lab [WIP] Expand and complete new surface lab Mar 24, 2019

"id": "rotovap",
"type": "TOOL",
"category": "tools",
"name": "rotary evapourator",

This comment has been minimized.

Copy link
@Night-Pryanik

Night-Pryanik Mar 24, 2019

Member
Suggested change
"name": "rotary evapourator",
"name": "rotary evaporator",
"type": "TOOL",
"category": "tools",
"name": "rotary evapourator",
"description": "Just looking at this thing makes you feel like a proper mad scientist. It's a series of glass tubes and round flasks, connected to a central motor and a heating element. The heating element warms one flask, kept rotating by the motor, evapourating the contents. The vapour is then condensed in the tubes and collected in another flask, in case you wanted to save it for later.",

This comment has been minimized.

Copy link
@Night-Pryanik

Night-Pryanik Mar 24, 2019

Member
Suggested change
"description": "Just looking at this thing makes you feel like a proper mad scientist. It's a series of glass tubes and round flasks, connected to a central motor and a heating element. The heating element warms one flask, kept rotating by the motor, evapourating the contents. The vapour is then condensed in the tubes and collected in another flask, in case you wanted to save it for later.",
"description": "Just looking at this thing makes you feel like a proper mad scientist. It's a series of glass tubes and round flasks, connected to a central motor and a heating element. The heating element warms one flask, kept rotating by the motor, evaporating the contents. The vapor is then condensed in the tubes and collected in another flask, in case you wanted to save it for later.",
{
"id": "hydrogen_tank",
"type": "TOOL",
"name": "nitrogen tank",

This comment has been minimized.

Copy link
@Night-Pryanik

Night-Pryanik Mar 24, 2019

Member
Suggested change
"name": "nitrogen tank",
"name": "hydrogen tank",
"type": "uncraft",
"skill_used": "electronics",
"difficulty": 4,
"skills_required": [ "cooking", 1 ],

This comment has been minimized.

Copy link
@Night-Pryanik

Night-Pryanik Mar 24, 2019

Member

I assume you meant that this recipe requires chemistry? I think chemistry in form of cooking begins at level 3.

@I-am-Erk

This comment has been minimized.

Copy link
Contributor Author

commented Mar 24, 2019

You're in the wrong PR, @Night-Pryanik. Those are changes from #28892 that are just inherited into this one.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/so-i-came-across-the-research-facility-superstructure/19434/2

@I-am-Erk

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

closing rather than fixing all these lints.

@I-am-Erk I-am-Erk closed this Apr 1, 2019

@I-am-Erk I-am-Erk deleted the I-am-Erk:lab-surface-2 branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.