Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooked Acorns calorie #29050

Merged
merged 4 commits into from Mar 27, 2019

Conversation

Projects
None yet
6 participants
@Fris0uman
Copy link
Contributor

commented Mar 27, 2019

Summary

SUMMARY: Balance "Cooked Acorns get same calorie value as Acorns instead of 8 times more"

Purpose of change

Cooked acorns recipe use 1 charge of acorns but has 456 ca instead of 114 ca and two portions.

Describe the solution

This changes the calorie value to 114 ca and the charges to 1.

Describe alternatives you've considered

Additional context

Forum discussion that brought the problem up.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/acorns-the-super-food/19404/34

@anothersimulacrum

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

There's no need to change the calories manually, you can just remove the "NUTRIENT_OVERRIDE" flag.

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

So I remove the calorie and the flag entry ?

@anothersimulacrum

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

It still needs the calorie entry, but if you remove the flag, it will inherit it's calorie value from what it's made from.

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Ok done, I removed the flag.

@ZhilkinSerg ZhilkinSerg merged commit 8e3072b into CleverRaven:master Mar 27, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gorgon-ghprb Build finished.
Details
@Mecares

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

The weight needs to be fixed now as well 30g of Acorns should not turn into 118g without adding anything to them, also acorn meal has according to a quick google search around 500 kcal per 100g and not around 100. Seems more like the problem was not that the result had too many calories but that too few acorns where required to craft them.

@Fris0uman Fris0uman deleted the Fris0uman:acorn branch Mar 28, 2019

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

Ok let's go back to the forum discussion because my research did not deliver the same results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.