Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove fire amplifying due to wind - caused everlasting fires #29115
Conversation
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/everburning-fires/19415/12 |
ZhilkinSerg
merged commit 7c6b603
into
CleverRaven:master
Mar 29, 2019
davidpwbrown
deleted the
davidpwbrown:fire_fix
branch
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
davidpwbrown commentedMar 29, 2019
Summary
SUMMARY: Bugfixes "Remove fire amplifying due to wind - caused everlasting fires"Purpose of change
Fixes #29060
Fixes #29046
Describe the solution
Introduced in #28058 added wind strength to field strength. so it never died out.
A better implementation would be to boost field strength but with diminishing returns, making it burn itself out quicker in high winds perhaps.
But for the moment I've just removed it the field amplifying
The other wind effects on spreading and smoke production will remain.
Describe alternatives you've considered
N/A
Additional context
N/A