Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Pet Armors for Dogs [CR] #29134

Merged
merged 6 commits into from Apr 4, 2019

Conversation

Projects
None yet
4 participants
@DracoGriffin
Copy link
Member

commented Mar 30, 2019

Summary

SUMMARY: Content "Adds new pet armors for canines with crafting recipes."

Purpose of change

Adds new pet armors with focus on canines (with foundation of proper materials, can be expanded to other pets more easily) since merging of #28646.

Describe the solution

The materials listed for armors may not 100% reflect (but I kept them as close as possible) as balancing pet resilience (how many "Tough Zombies" they could kill one-on-one in a small lit room before dying) was very difficult as increasing material thickness by 1 could dramatically increase pet resilience.

For instance, the "Chainmail dog coat" when set to JUST

    "material": [ "iron" ],
    "material_thickness": 2,

would allow a German Shepherd to take down 21 Tough Zombies, but changing it to:

    "material": [ "iron", "leather" ],
    "material_thickness": 1,

and they could only take down 6.

Additionally, pet resilience is null against groups of zombies, they quickly die so keep in mind the following data when used just to balance one-on-one damage protection against average zombie attacks. (Interestingly, the amount of Tough Zombies the German Shepherds could kill was similar to the hits taken/amount of turns they lasted against Zombie Hulks, fun statistics!)

Also, German Shepherds are rare and the strongest of the dog breeds (the average would be Labrador or Pit Bulls in both combat ability and group spawns), so resilience may be artificially higher than normal.

I followed the player armor trend to correlate pet armors (so there wouldn't be any abnormalities like Plastic giving more protection than Iron):

Naked/None <= Plastic < Leather <= Bone/Leather < Iron < Kevlar < Chitin < AcidChitin < Superalloy.

However, purely based on singular material did not uphold this so I had to force compliance by interweaving "similar" materials to follow this evolution more closely. This is what I ended up with:

Average kills in parentheses.
Naked/None (2) <= Neoprene/Plastic (4) < Cotton/Leather (7) <= Bone/Leather (8) < Budget Steel/Iron (14) < Kevlar (12) < Chitin (27) < AcidChitin (28) < Superalloy (infinite?) .

Ideally I'd like to get to these numbers but would require further pet armor coding to allow greater control over cut/bash resistances, so is beyond this PR:
None (2) <= "Rainsuit" (3) < "Leather harness" (6) <= "Decorative bone leather harness" (6-7) < "Chainmail coat" (9) <= "Kevlar harness" (9-10) < "Chitin mesh harness" (14) < "AcidChitin mesh harness" (16) < "Superalloy outfit/harness" (20) .

Recipes were based on relevant armors and downsized somewhat appropriately by 25%, with some difficulties increased (shaping the material to an animal can be trickier given different locomotion [bipedal vs quadruped and gaits]).

Inspiration for rainsuit.

Inspiration for harnesses.

Added new crafting categories (since pet armor can be applied to different body types, can be added as they are made).

The superalloy version is basically locked to debug only, it was more for testing, but could be an extremely rare drop or perhaps made with the #27106 - Nanofabricator.

NO_SALVAGE applied to leather harness (gave back way too much rags and leather patches for some reason) and rainsuit (yielded neoprene sheets).

Describe alternatives you've considered

Keeping to mod only.

Additional context

Murder Testing Room
Well-lit with overhead lights so Tough Zombie and (Armored) German Shepherd always had sight to engage; one Tough Zombie would be spawned on alternate staircases after each Tough Zombie died until German Shepherd perished. Corpses were tracked and cleaned up between tests (to avoid revivifications disrupting tests).
petarmortesting

DracoGriffin added some commits Mar 30, 2019

Add new pet armor for canines
Moves pet armor to new JSON and adds recipes to craft new canine pet armors.
Add NO_SALVAGE flags
Cutting up leather harness and rainsuit were yielding inappropriate items
Update grammar
Clean up temporary descriptions to more formal version.
Remove old comment
Comment no longer relevant once material was changed from iron+leather to iron+budgetsteel.
@tinukedaya

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

I can't imagine a dog being able to fight in chainmail armor. It would be more resilient, sure... but I would think also unable to fight effectively. I'd love to see some padded/leather/kevlar harnesses, yes. But that would be it. For dog to be effective in fighting it needs freedom of movement.

just my 2 cents.

@DracoGriffin

This comment has been minimized.

Copy link
Member Author

commented Mar 31, 2019

I can't imagine a dog being able to fight in chainmail armor. It would be more resilient, sure... but I would think also unable to fight effectively. I'd love to see some padded/leather/kevlar harnesses, yes. But that would be it. For dog to be effective in fighting it needs freedom of movement.

just my 2 cents.

Thank you for the feedback, I appreciate it.

Honestly, I am on board with that, as it has proven quite difficult to find some solid results from barding/armoring dogs. They have been used throughout history and shown with differing types of armor, but I haven't found anything yet that states "was ineffective" or "improved survivability and kill ratios". Basically for chain mail, I can't determine how much was for combat and how much was for show/decorative. Image 4 shows a use of chainmail harness to allow that freedom of movement, but I really don't know how effective it is for something like Hog Dogging, as Kevlar seems to be the preferred material vest. Link 1 2

Further reading: Dogs of the Conquistadors, Dogs of the Conquest

Images: 1 2 3 4

The one thing that I didn't add because there isn't code to support it, but spiked collars/torsos seems consistent throughout history. So I could mimic "resilience" by not being able to attack or harm dog directly (because spikes hurt), but there wouldn't be any inflicted bleeding damage or damage at all.

Luath wore a heavy metal collar with sharpened spikes, and also hardened leather body armor to protect him from blows and knife wounds when he went into battle.

@ZhilkinSerg ZhilkinSerg self-assigned this Apr 2, 2019

@tinukedaya

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

What I was worried about is the kind of "full body" armors shown in some of the pictures. Those will hinder the attack abilities of the dogs in my opinion and were probably just decorative.

But the more practical ones, like the of the anti-bite chain mail you pictured and those shown in the pics in the Dogs of the Conquistadors, those might work I guess. From what I can see, they have quite low coverage so still allow freedom of movement... So I will just think about it that way. Maybe have it somehow mentioned in the description? e.g. "A makeshift harness of chitin fitted to a thin mesh harness protecting the chest and shoulders of canines."

Maybe sometime in the future the items would work with proper encumbrance and coverage and will affect the dogs stats.

btw: the spike collars would be awesome!

Fix flags and descriptions
- Correct flag usage by ZhilkinSerg
- Update descriptions to visualize vest/harness coverage by tinukedaya
@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Later we should make pet armor menu more like "Wear" menu:

image

image

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

AIso something for doing later - it would be nice if "Monster" and "Look Around" menu would show armor on pets:

image

image

@ZhilkinSerg ZhilkinSerg merged commit 005fb88 into CleverRaven:master Apr 4, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gorgon-ghprb Build finished.
Details

@ZhilkinSerg ZhilkinSerg removed their assignment Apr 4, 2019

@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/latest-experimental-features/5582/1106

@DracoGriffin DracoGriffin deleted the DracoGriffin:PetArmor_Dogs branch Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.