Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NPC sound ignoring logic to reduce activity interruptions. #29207

Merged
merged 2 commits into from Apr 1, 2019
Merged

Improve NPC sound ignoring logic to reduce activity interruptions. #29207

merged 2 commits into from Apr 1, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 1, 2019

Summary

SUMMARY: Bugfixes "Improve NPC sound ignoring logic to reduce activity interruptions."

Purpose of change

Couldn't find an existing issue, but have seen people discussing this - when digging a pit or chopping a tree, friendly NPCs will keep whining about the noise, and interrupting your activity.

Describe the solution

I've added a new sound_type - destructive_activity.
new logic is :
allies will not comment or investigate any sound the player produces except for combat / alert noises ( shouting etc )
If the player dosnt see it, and neither does the NPC and it's medium priority or higher sounds ( movement, speech etc ) they will investigate.

Neutral NPCS will investigate and comment on destructive activities the player produces ( drilling, sawing , pickaxing, etc ) but ignore all other activities ( digging, chopping trees ) that the player produces.
They will investigate medium priority or higher sounds they dont see and the player dosnt see.

Hostile NPCs will investigate irrespective of whether the player produced it or not.

This abstracts out the mechanism by which a player might tell neutral or friendly NPCS "dont worry! it was just me making that noise"

Drilling walls with a jackhammer in their base though should still prompt them to be curious.

Describe alternatives you've considered

N/A

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Apr 1, 2019
@ZhilkinSerg ZhilkinSerg merged commit 1500439 into CleverRaven:master Apr 1, 2019
@ghost ghost deleted the ally_sound_ignore branch April 2, 2019 11:19
@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/npc-yells-at-me-when-i-do-stuff/19471/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants