Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dry_rice from beans_cooked recipe. #29270

Merged
merged 2 commits into from Apr 4, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Crafting / Construction / Recipes Food / Vitamins Game: Balance [JSON]
Projects
None yet
Milestone
No milestone
4 participants
@anonym @ifreund @kevingranade @ZhilkinSerg
@anonym
Copy link
Contributor

commented Apr 4, 2019

Summary

SUMMARY: Bugfixes "Drop dry rice from the cooked beans recipe"

Purpose of change

This is a simple follow-up on #29086 which reverts a bug it introduced.
@anonym
Drop dry_rice from beans_cooked recipe. 
That component was erroneously added in this PR:

    #29086

Cheers to Cynicus26 and MamaLlama on discourse for finding the bug and
connecting it to my PR to it was brought to my attention!
Loading status checks…
8e2cdb9
@ifreund

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Apr 4, 2019

You need to lint your json changes

@ifreund ifreund added [JSON] Crafting / Construction / Recipes Game: Balance Food / Vitamins labels Apr 4, 2019

@ZhilkinSerg
Linted
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b432c4b

@ZhilkinSerg ZhilkinSerg merged commit 8c72559 into CleverRaven:master Apr 4, 2019
1 of 3 checks passed

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gorgon-ghprb Build finished.
Details
@kevingranade

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 5, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/cooked-beans-recipe-beans-and-rice-recipe/19512/4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.