Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAscii offset fixes #29359
Conversation
reed501
added some commits
Apr 7, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/various-off-center-view-bugs-in-ascii/19535/3 |
ifreund
added
<Bugfix>
[C++]
Info / User Interface
labels
Apr 7, 2019
kevingranade
merged commit f070115
into
CleverRaven:master
Apr 8, 2019
This comment has been minimized.
This comment has been minimized.
Chryseus
commented
Apr 8, 2019
|
There is still an offset when adding a new zone that needs to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
reed501 commentedApr 7, 2019
•
edited by Night-Pryanik
Summary
SUMMARY: Bugfixes "Fixes offset issues in ascii caused by the sidebar"Purpose of change
Closes #29256 - Action highlights off center due to sidebar changes
Closes #29186 - Vehicle crosshair off center due to sidebar changes
Fixes #29192 - Weather doesn't appear on the left side of screen due to sidebar changes
Describe the solution
In places that were forgotten in the sidebar update, I added or subtracted g->sidebar_offset where needed to realign parts of the UI.
Describe alternatives you've considered
Another way of going about all this I briefly considered before being terrified of it is to have the mechanisms that draw things to a location on screen have the offset built in, rather than offsetting at the top level.
Additional context
There's still more to be done. In combat for a fraction of a second an animation appears and it is off center, not sure where that is. Also I don't think my solution for weather animation is as robust as it could be. It seems to work for now however. If new issues appear I will try again.