Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTurn static NPCs and z-levels on by default #29435
Conversation
I-am-Erk
added
NPC / Factions
Z-levels
labels
Apr 9, 2019
DracoGriffin
reviewed
Apr 10, 2019
src/options.cpp Outdated
HeShallNot
reviewed
Apr 10, 2019
src/options.cpp Outdated
kevingranade
merged commit a892c82
into
master
Apr 10, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/latest-experimental-features/5582/1106 |
kevingranade
deleted the
NPC-defaults
branch
Apr 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
I-am-Erk commentedApr 9, 2019
Summary
SUMMARY: Interface "Turns static/scenario NPCs and 'experimental' z-levels on by default"Purpose of change
The current experimental version moving towards 0.E is defined largely by improvements to NPC AI and Z-level handling. These features should be enabled by default now that they're functional for play, and to encourage playtesting.
Describe the solution
Enables both features by default and updates the description of z-levels.
Describe alternatives you've considered
This does not enable dynamic NPC spawns by default, as those are still a ways from being functional.
Additional context
I don't have a compiler so I can't playtest this. It's hard to imagine what could go wrong with a simple config change... but those are some famous last words.