Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new static NPC in city. #29529

Merged
merged 5 commits into from Apr 14, 2019

Conversation

Projects
None yet
7 participants
@curstwist
Copy link
Contributor

commented Apr 13, 2019

Summary

SUMMARY: Content "Adds a static npc that spawns in a restaurant. Adjusts the back room they spawn in with extra loot and slight fortifications."

Purpose of change

Start populating the city with new NPCs. This NPC spawns with a slightly fortified variation of the back room of s_restaurant.json. Depending on feedback, I can make some more.

Describe the solution

Adds an NPC chef that has remained at their workplace since the cataclysm, living off of the supplies.

Describe alternatives you've considered

Not touching npcs.

Additional context

Chef NPC, spawns with chefs clothing and a butchers knife. Chance of higher cooking and throwing skills. They are pretty likely to go pick a fight if they hear zombies, so that's interesting. They also spawn with a generous hoard of food, mostly perishable. Once ownership becomes functional, I can adjust the NPC to own the loot.

Backroom with NPC spawn & without.
NPC chef spawn
npc free

Add new static NPC in city.
adds a static npc that spawns in a restaurant.  Adjusts the back room they spawn in with extra loot and slight fortifications.
@ifreund

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

This is pretty sweet, I think it would be awesome to see the world populated with more, flavorful static NPCs like this one

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

Yeah, that's something I wanted to do myself sometime.

Night-Pryanik and others added some commits Apr 13, 2019

Update data/json/npcs/TALK_SURVIVOR_CHEF.json
thanks, for fixing this!

Co-Authored-By: curstwist <39442864+curstwist@users.noreply.github.com>
Update data/json/npcs/TALK_SURVIVOR_CHEF.json
Co-Authored-By: curstwist <39442864+curstwist@users.noreply.github.com>
Update data/json/npcs/TALK_SURVIVOR_CHEF.json
Co-Authored-By: curstwist <39442864+curstwist@users.noreply.github.com>
@curstwist

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2019

Yeah, that's something I wanted to do myself sometime.

I-am-Erk has the same idea too, so I guess it's time has come :). This should give a rough template for others to follow. Someone can also improve its dialogue later, which isn't my strength.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/faction-a-benign-religious-sect/19668/2

@ZhilkinSerg ZhilkinSerg self-assigned this Apr 14, 2019

@ZhilkinSerg ZhilkinSerg merged commit 1ef99b9 into CleverRaven:master Apr 14, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gorgon-ghprb Build finished.
Details

@ZhilkinSerg ZhilkinSerg removed their assignment Apr 14, 2019

@Mecares

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Maybe add a hostile (unless the player is cannibal himself) cannibal variant, that has a rather gruesome hoard of preserved food.

@curstwist curstwist deleted the curstwist:add-city-chef-npc branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.