Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd piles of straw as a byproduct to cutting grass #29584
Conversation
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/adding-resources-from-construction/19678/4 |
This comment has been minimized.
This comment has been minimized.
|
Summary line needs to be |
I-am-Erk
approved these changes
Apr 15, 2019
|
This is something I've wanted for a long time and keep forgetting to add. Thanks. Some small balance suggestions here but it could go in as is without problems too. |
data/json/construction.json
Outdated
| @@ -1901,6 +1904,7 @@ | |||
| "required_skills": [ [ "survival", 0 ] ], | |||
| "time": 6, | |||
| "qualities": [ [ { "id": "DIG", "level": 1 } ] ], | |||
| "byproducts": [ { "item": "straw_pile", "count": [ 1, 2 ] } ], | |||
This comment has been minimized.
This comment has been minimized.
I-am-Erk
Apr 15, 2019
Contributor
I'd suggest for long grass just keep it as a guaranteed yield of 1.
data/json/construction.json
Outdated
| @@ -1880,6 +1881,7 @@ | |||
| "category": "OTHER", | |||
| "required_skills": [ [ "survival", 0 ] ], | |||
| "time": 6, | |||
| "byproducts": [ { "item": "straw_pile", "count": [ 0, 1 ] } ], | |||
This comment has been minimized.
This comment has been minimized.
I-am-Erk
Apr 15, 2019
Contributor
For tall grass here I'd say you could get away with a guaranteed yield of 1.
kevingranade
added some commits
Apr 20, 2019
kevingranade
merged commit 3fae041
into
CleverRaven:master
Apr 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jokermatt999 commentedApr 14, 2019
•
edited
Summary
SUMMARY: Features "Add piles of straw as a byproduct from cutting grass."Purpose of change
"The ability to cut grass is basically useless currently since it requires fairly rare tools and doesn’t give you anything but an easier tile to walk on...if cutting down tall and long grass actually yielded piles of straw it would have a use for quickly stockpiling the material for camp construction or other crafts that allow piles of straw.
Describe the solution
Added byproduct entries to cut grass construction (barring golf grass and white grass)
Describe alternatives you've considered
Increasing straw pile yield, but decided against it
Additional context
Initial suggestion by Trigon here: https://discourse.cataclysmdda.org/t/adding-resources-from-construction/19678