Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add piles of straw as a byproduct to cutting grass #29584

Merged
merged 4 commits into from Apr 20, 2019

Conversation

Projects
None yet
4 participants
@jokermatt999
Copy link
Contributor

commented Apr 14, 2019

Summary

SUMMARY: Features "Add piles of straw as a byproduct from cutting grass."

Purpose of change

"The ability to cut grass is basically useless currently since it requires fairly rare tools and doesn’t give you anything but an easier tile to walk on...if cutting down tall and long grass actually yielded piles of straw it would have a use for quickly stockpiling the material for camp construction or other crafts that allow piles of straw.

Describe the solution

Added byproduct entries to cut grass construction (barring golf grass and white grass)

Describe alternatives you've considered

Increasing straw pile yield, but decided against it

Additional context

Initial suggestion by Trigon here: https://discourse.cataclysmdda.org/t/adding-resources-from-construction/19678

@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/adding-resources-from-construction/19678/4

@ifreund

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2019

Summary line needs to be
SUMMARY: Features "Add piles of straw as a byproduct from cutting grass."

@I-am-Erk
Copy link
Contributor

left a comment

This is something I've wanted for a long time and keep forgetting to add. Thanks.

Some small balance suggestions here but it could go in as is without problems too.

@@ -1901,6 +1904,7 @@
"required_skills": [ [ "survival", 0 ] ],
"time": 6,
"qualities": [ [ { "id": "DIG", "level": 1 } ] ],
"byproducts": [ { "item": "straw_pile", "count": [ 1, 2 ] } ],

This comment has been minimized.

Copy link
@I-am-Erk

I-am-Erk Apr 15, 2019

Contributor

I'd suggest for long grass just keep it as a guaranteed yield of 1.

@@ -1880,6 +1881,7 @@
"category": "OTHER",
"required_skills": [ [ "survival", 0 ] ],
"time": 6,
"byproducts": [ { "item": "straw_pile", "count": [ 0, 1 ] } ],

This comment has been minimized.

Copy link
@I-am-Erk

I-am-Erk Apr 15, 2019

Contributor

For tall grass here I'd say you could get away with a guaranteed yield of 1.

kevingranade added some commits Apr 20, 2019

@kevingranade kevingranade merged commit 3fae041 into CleverRaven:master Apr 20, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gorgon-ghprb Build triggered for merge commit.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.