Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle liquids on completion of craft #29687
Conversation
ifreund
added
Crafting / Construction / Recipes
[C++]
<Bugfix>
labels
Apr 18, 2019
This comment has been minimized.
This comment has been minimized.
|
jenkins rebuild |
ZhilkinSerg
merged commit e2a75d5
into
CleverRaven:master
Apr 18, 2019
ifreund
deleted the
ifreund:craft-liquid
branch
Apr 18, 2019
ZhilkinSerg
referenced this pull request
Apr 19, 2019
Closed
Crafting using the new system drops or vanishes liquids #29708
ifreund
referenced this pull request
Apr 19, 2019
Closed
Clean water doesn't appear after crafting #29740
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/bug-crafting-liquids-in-recent-experimental/19718/5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ifreund commentedApr 18, 2019
Summary
SUMMARY: Bugfixes "Handle liquids on completion of craft."Purpose of change
Fixes #29677.
Describe the solution
Check for and handle liquids upon completion of the craft before trying to wield the result or place it on the workbench/map.
Additional context
This supersedes #29678 which doesn't handle liquids if using a workbench or crafting on the ground. Many thanks to @ZhilkinSerg for helping to clean up after me though.