Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace all instances of "plumber_gear" with "hardware_plumbing" #29728
Conversation
ifreund
referenced this pull request
Apr 19, 2019
Closed
more_locations mapgen weights plumber_gear error #29729
This comment has been minimized.
This comment has been minimized.
|
Fixes #29729 |
ZhilkinSerg
added
<Bugfix>
[JSON]
Mods
labels
Apr 19, 2019
ZhilkinSerg
merged commit 2c7d249
into
CleverRaven:master
Apr 19, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/bug-cant-start-a-game/19729/5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Saint-of-Grey commentedApr 19, 2019
•
edited by ZhilkinSerg
Summary
SUMMARY: Bugfixes "Replace all instances of plumber_gear with hardware_plumbing"
Purpose of change
Fixes #29729
To fix the "More Locations" mod.
Describe the solution
It would appear "plumber_gear" got changed to "hardware_plumbing" in the main game, but not the included mods.
Literally a find/replace operation to update "plumber_gear" to "hardware_plumbing".
Describe alternatives you've considered
Letting the game remain broken and going to bed instead.
Additional context
Seemed like something I could fix myself, so I did.