Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upDraw highlights in tiles #29840
Conversation
ifreund
added some commits
Apr 22, 2019
ifreund
added
<Enhancement / Feature>
Info / User Interface
[JSON]
SDL: Tiles / Sound
[C++]
labels
Apr 22, 2019
ZhilkinSerg
self-assigned this
Apr 23, 2019
ZhilkinSerg
merged commit 5a102c1
into
CleverRaven:master
Apr 23, 2019
ZhilkinSerg
removed their assignment
Apr 23, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/32x32-msx-dead-people-tileset/18775/161 |
ifreund
deleted the
ifreund:tiles-highlight
branch
Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ifreund commentedApr 22, 2019
Summary
SUMMARY: Features "Draw highlights in tiles (e.g. when examining)."Purpose of change
While working on some other changes, I noticed that in curses actions such as examine draw a highlight on valid targets by inverting the colors at those points. However, there was no equivalent in tiles.
Describe the solution
This pull request adds a new graphic
highlightthat can be drawn very similarly to how a cursor is drawn.I also set this to the same sprite as
cursorfor all tilesets, as this is a workable fallback until tileset maintainers replace it.